From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
lse <lse-tech@lists.sourceforge.net>,
Rik van Riel <riel@conectiva.com.br>
Subject: Re: [Lse-tech] [patch] Scalable statistics counters with /proc reporting
Date: Thu, 8 Aug 2002 10:11:45 +0530 [thread overview]
Message-ID: <20020808101145.C12301@in.ibm.com> (raw)
In-Reply-To: <3D516EB5.E8669146@zip.com.au>; from akpm@zip.com.au on Wed, Aug 07, 2002 at 12:02:14PM -0700
On Wed, Aug 07, 2002 at 12:02:14PM -0700, Andrew Morton wrote:
> Christoph Hellwig wrote:
> >
> > ...
> > Also the /proc-based implementation is really ugly. It should be moved
> > over to the seq_file interface at least, a simple ramfs-style own
> > filesystem ("stats" filesystem type) would be the cleanest solution.
>
> I'd suggest that it be just a single stat counter per /proc
> file. A simple sprintf is fine for that.
>
> If it's necessary to write a new filesystem to just export a bunch
> of integers to userspace then something is seriously wrong.
Yes, that was how my previous release worked. But Rik wanted to be able
to group a bunch of counters into a single /proc file for his use.
Rik, your comments please... what do you prefer? current /proc style,
seq_file, or the earlier "one counter per /proc" style?
Thanks,
Kiran
next prev parent reply other threads:[~2002-08-08 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-07 8:52 [patch] Scalable statistics counters with /proc reporting Ravikiran G Thirumalai
2002-08-07 9:02 ` [Lse-tech] " Christoph Hellwig
2002-08-07 19:02 ` Andrew Morton
2002-08-08 4:41 ` Ravikiran G Thirumalai [this message]
2002-08-08 9:39 ` Ravikiran G Thirumalai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020808101145.C12301@in.ibm.com \
--to=kiran@in.ibm.com \
--cc=akpm@zip.com.au \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.