Re: [patch 13/21] deferred and batched addition of faulted-in pages to the LRU

[Andi Kleen <ak@suse.de>]

On Sun, Aug 11, 2002 at 02:48:23AM -0700, Andrew Morton wrote:
> Andi Kleen wrote:
> > 
> > Andrew Morton <akpm@zip.com.au> writes:
> > >   */
> > > -void lru_cache_add(struct page * page)
> > > +static struct pagevec lru_add_pvecs[NR_CPUS];
> > > +
> > > +void lru_cache_add(struct page *page)
> > > +{
> > > +     struct pagevec *pvec = &lru_add_pvecs[get_cpu()];
> > 
> > This should probably use the linux/percpu.h macros.
> > This way it could be more efficient on some architectures and also avoid
> > potential false sharing.
> 
> Yes, I need to do a sweep sometime and convert some things like
> that. Preferably after the hot-remove APIs are there.  Or is
> that not planned?

I would see them as independent problems. No need to stall one by the other.

-Andi