From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin LaHaise Subject: Re: PATCH - SUNRPC 1 of 3 - The new "sk_flags" word in struct svc_sock must be long.... Date: Tue, 20 Aug 2002 19:21:58 -0400 Sender: nfs-admin@lists.sourceforge.net Message-ID: <20020820192158.P21269@redhat.com> References: <15713.50328.541517.124690@notabene.cse.unsw.edu.au> <20020820185357.O21269@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: nfs@lists.sourceforge.net Return-path: Received: from to-velocet.redhat.com ([216.138.202.10] helo=touchme.toronto.redhat.com) by usw-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 17hIK1-0004tG-00 for ; Tue, 20 Aug 2002 16:22:01 -0700 To: Trond Myklebust In-Reply-To: ; from trond.myklebust@fys.uio.no on Wed, Aug 21, 2002 at 01:16:12AM +0200 Errors-To: nfs-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Unsubscribe: , List-Archive: On Wed, Aug 21, 2002 at 01:16:12AM +0200, Trond Myklebust wrote: > > On Tue, Aug 20, 2002 at 02:24:56PM +1000, Neil Brown wrote: > >> @@ -22,7 +22,7 @@ struct svc_sock { > >> > >> struct svc_serv * sk_server; /* service for this socket */ > >> unsigned char sk_inuse; /* use count */ > >> - unsigned int sk_flags; > >> + unsigned long sk_flags; > > > Cool, 7 bytes of useless padding on 64 bit architectures. > > All down to the sad inability of certain 64-bit "processor architects" > to provide for atomic bit operations on 32-bit integers. > If the relatively minor bloat in knfsd worries you, then I advise you > to take a deep breath before peeking at struct page... 8-) You've missed the point. Between sk_inuse and sk_flags is 7 bytes of padding. Yes, I'm aware that sk_flags has 7 bytes of unused space, but that's the unavoidable part. Personally, I think the sunrpc code should do this particular operation differently. -ben -- "You will be reincarnated as a toad; and you will be much happier." ------------------------------------------------------- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs