From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [BUG/PATCH] : bug in tty_default_put_char()
Date: Mon, 26 Aug 2002 11:59:30 -0700 [thread overview]
Message-ID: <20020826185930.GA8749@bougret.hpl.hp.com> (raw)
In-Reply-To: <1030388224.2797.2.camel@irongate.swansea.linux.org.uk>
On Mon, Aug 26, 2002 at 07:57:04PM +0100, Alan Cox wrote:
> On Mon, 2002-08-26 at 19:07, Jean Tourrilhes wrote:
> > Hi,
> >
> > Bug : tty_default_put_char() doesn't check the return value of
> > tty->driver.write(). However, the later may fail if buffers are full.
> >
> > Solution : It's not obvious what should be done. The attached
> > patch is certainly wrong, but gives you an idea of what the problem
> > is.
>
> Make it an int and return the tty->driver.write value. We know that
> since its void nobody is currently checking the error code, and now they
> can where it matters
Just check drivers/char/n_tty.c for every occurence of
put_char() and be scared. The problem is to find a practical solution.
For myself, I've added some clever workaround in IrCOMM to
accept data before full setup.
Regards,
Jean
next prev parent reply other threads:[~2002-08-26 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-26 18:07 [BUG/PATCH] : bug in tty_default_put_char() Jean Tourrilhes
[not found] ` <1030388224.2797.2.camel@irongate.swansea.linux.org.uk>
2002-08-26 18:59 ` Jean Tourrilhes [this message]
2002-08-26 19:07 ` Alan Cox
2002-08-26 20:17 ` Russell King
2002-08-26 19:31 ` Russell King
[not found] ` <20020826195346.GC8749@bougret.hpl.hp.com>
[not found] ` <20020826210159.E4763@flint.arm.linux.org.uk>
[not found] ` <20020826201732.GE8749@bougret.hpl.hp.com>
[not found] ` <20020826212223.H4763@flint.arm.linux.org.uk>
2002-08-28 22:41 ` Jean Tourrilhes
2002-08-28 23:16 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020826185930.GA8749@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.