All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <syrjala-ORSVBvAovxo@public.gmane.org>
To: valvo <valvoline-FEXhGYRT/JJAfugRpC6u6w@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: patch: acpi-20020821 fix?
Date: Thu, 29 Aug 2002 18:20:33 +0300	[thread overview]
Message-ID: <20020829182033.A23001@sci.fi> (raw)
In-Reply-To: <20020829144434.GB246-eODHXEvUBeUUXDL+gvDWyA@public.gmane.org>; from valvoline-FEXhGYRT/JJAfugRpC6u6w@public.gmane.org on Thu, Aug 29, 2002 at 04:44:34PM +0200

On Thu, Aug 29, 2002 at 04:44:34PM +0200, valvo wrote:
> On Tue, Aug 27, 2002 at 02:55:25AM -0400, Giridhar Pemmasani wrote:
> >     /* only support S1 and S5 on kernel 2.4 */
> > -   if (state != ACPI_STATE_S1 || state != ACPI_STATE_S5)
> > +   if (state != ACPI_STATE_S1 && state != ACPI_STATE_S5)
> >         return AE_ERROR;
>
> i don't understand the purpouses of this patch...can you be more explicit, plz ?

Looks clear to me. Without this change the condition is always true.

-- 
Ville Syrjälä
syrjala-ORSVBvAovxo@public.gmane.org
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

  parent reply	other threads:[~2002-08-29 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-27  6:55 patch: acpi-20020821 fix? Giridhar Pemmasani
     [not found] ` <15723.8797.507913.189282-KT8MnZFsUJrzAs+eN625g9BFLwJMpSEX@public.gmane.org>
2002-08-29 14:44   ` valvo
     [not found]     ` <20020829144434.GB246-eODHXEvUBeUUXDL+gvDWyA@public.gmane.org>
2002-08-29 15:13       ` Matthew Wilcox
2002-08-29 15:20       ` Ville Syrjälä [this message]
     [not found]         ` <20020829182033.A23001-ORSVBvAovxo@public.gmane.org>
2002-08-29 20:47           ` valvo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020829182033.A23001@sci.fi \
    --to=syrjala-orsvbvaovxo@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=valvoline-FEXhGYRT/JJAfugRpC6u6w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.