From: Ralf Baechle <ralf@linux-mips.org>
To: Vivien Chappelier <vivien.chappelier@enst-bretagne.fr>
Cc: Brian Murphy <brm@murphy.dk>, linux-mips@oss.sgi.com
Subject: Re: [PATCH 2.5] R5000 secondary cache support
Date: Tue, 3 Sep 2002 00:35:52 +0200 [thread overview]
Message-ID: <20020903003552.L15618@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.21.0208262136090.485-100000@melkor>; from vivien.chappelier@enst-bretagne.fr on Mon, Aug 26, 2002 at 09:49:37PM +0200
On Mon, Aug 26, 2002 at 09:49:37PM +0200, Vivien Chappelier wrote:
> I've tested and updated Brian Murphy's R5K SC patch to the 2.5
> kernel. I've also changed a few comments, changed Page_Invalidate
> operation to R5K_Page_Invalidate_S to be consistent with the naming of R4K
> cache ops, and simplified the r5k_dma_cache_inv_sc routine (no need for
> two 'while'). And I've also removed the extra crap for in config-shared.in
> in Brian's latest diff (removing spaces/formating) :)
>
> I've also tested this patch at runtime, it runs fine (as far as
> a 2.5.8 can run fine :)). This patch is for both 2.5.8/mips64 and
> 2.5.8/mips.
>
> Please comment and/or apply,
Mostly ok. I just don't like that you force CONFIG_BOARD_SCACHE on
everybody with a R5000 or Nevada. Cobalt Qube 1 for example has a Nevada
which never has a second level cache, whatever type. So if you could
fix that eventually :-)
Ralf
parent reply other threads:[~2002-09-02 22:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Pine.LNX.4.21.0208262136090.485-100000@melkor>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020903003552.L15618@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=brm@murphy.dk \
--cc=linux-mips@oss.sgi.com \
--cc=vivien.chappelier@enst-bretagne.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.