All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compile fix for fs/aio.c on non-highmem systems
Date: Tue, 3 Sep 2002 13:06:12 -0400	[thread overview]
Message-ID: <20020903130612.F21268@redhat.com> (raw)
In-Reply-To: <20020830.163656.76075937.davem@redhat.com>; from davem@redhat.com on Fri, Aug 30, 2002 at 04:36:56PM -0700

On Fri, Aug 30, 2002 at 04:36:56PM -0700, David S. Miller wrote:
> Or that since the enumeration values are basically identical
> on every system that the belong in linux/kmap_types.h :-)

The main problem here is that one needs different kmap types depending 
on which context a function is called from (which is why I needed the 
enum as a parameter to the function).  Unfortunately, the amount of 
memory needed for ringbuffers can grow pretty large on a system with 
many tasks, so not kmapping them isn't an option.  Making it a #define 
certainly works quite well, but if someone has a better idea to the 
kmap mess, I'd love to see it improved.

		-ben
-- 
"You will be reincarnated as a toad; and you will be much happier."

      reply	other threads:[~2002-09-03 17:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-26 21:53 [PATCH] compile fix for fs/aio.c on non-highmem systems Benjamin LaHaise
2002-08-30 23:21 ` David S. Miller
2002-08-30 23:42   ` Linus Torvalds
2002-08-30 23:36     ` David S. Miller
2002-09-03 17:06       ` Benjamin LaHaise [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020903130612.F21268@redhat.com \
    --to=bcrl@redhat.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.