From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: JFS extended attributes and ACLs - New Patches Date: Mon, 9 Sep 2002 10:28:44 -0500 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <200209091028.44124.shaggy@austin.ibm.com> References: <200209090958.40221.shaggy@austin.ibm.com> <200209091702.55163.agruen@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: acl-devel@bestbits.at, linux-fsdevel@vger.kernel.org Return-path: To: Andreas Gruenbacher In-Reply-To: <200209091702.55163.agruen@suse.de> List-Id: linux-fsdevel.vger.kernel.org On Monday 09 September 2002 10:02, Andreas Gruenbacher wrote: > Extended user attributes should be allowed only for regular files and > for directories with the sticky bet cleared. Rationale: See the > attr(5) manual page. Hmm. If different policies are to be applied to the different namespaces, I think it would be a good thing to move that policy to the vfs layer, rather than have each filesystem redundantly enforce these policies. If the VFS is requesting that an extended attribute be set, the filesystem-specific code should be able to assume it's allowed. I've tried to keep the JFS code simple. It really doesn't care and doesn't want to care about namespaces. I've special cased the setting of acl's to make sure the permissions get set correctly, but I'd prefer this happened at a higher level as well. Would you consider a patch to migrate the namespace-specific code into the vfs layer, and just let the file systems worry about the storage? > > The patches are available here: > > http://www-124.ibm.com/developerworks/patch/?func=detailpatch&patch > >_id=351& group_id=35 > > http://www-124.ibm.com/developerworks/patch/?func=detailpatch&patch > >_id=352& group_id=35 > > Are these links permanent? In the sense that they aren't going away. Later versions will probably have different urls. If you want a static link, you can use: http://oss.software.ibm.com/developerworks/patch/?group=35 > > --Andreas. -- David Kleikamp IBM Linux Technology Center