Re: Oops + Aiee when mounting CDROM via ide-scsi under 2.4.20-pre5-ac4

[Jens Axboe <axboe@suse.de>]

On Tue, Sep 10 2002, Martin Knoblauch wrote:
> Hi,
> 
>  I am getting a reproducable Oops+Aiee when trying to mount a ATAPI 
> CDROM via the ide-scsi interface under 2.4.20-pre5-ac4. Works OK 
> without ide-scsi.

Ok, the problem is that ide-scsi builds a request which eventually ends
up going through the ide code dma mapping. ide_build_sglist() does a
rq_data_dir() on the request, which BUG()'s if the command isn't an fs
read or write. This actually went undetected before, because the ide
code did:

	if (rq->cmd == READ)
		direction is dma from device
	else
		direction is to device

and rq->cmd is IDESCSI_PC_RQ in this case. So we always mapped for dma
to the device, even if that wasn't the case.

Hmm, maybe just adding a single direction bit to struct request is the
easy way out for 2.4. Or... I'll cook something up.

-- 
Jens Axboe