From: Jens Axboe <axboe@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] highmem I/O for ide-pmac.c
Date: Wed, 11 Sep 2002 15:07:54 +0200 [thread overview]
Message-ID: <20020911130754.GM1089@suse.de> (raw)
In-Reply-To: <20020911130209.GL1089@suse.de>
On Wed, Sep 11 2002, Jens Axboe wrote:
> Also, can you grow sg segments indefinitely?
Maybe you copied that from ide-dma? I think it would be safer to just
remove it, btw, there's no (if any) benefit to making the sg segments
bigger than a page since we'll much sooner hit the max sectors
limitation than the segment one.
Marcelo, please apply.
--- drivers/ide/ide-dma.c~ 2002-09-11 15:06:48.000000000 +0200
+++ drivers/ide/ide-dma.c 2002-09-11 15:07:26.000000000 +0200
@@ -268,15 +268,6 @@
struct scatterlist *sge;
/*
- * continue segment from before?
- */
- if (bh_phys(bh) == lastdataend) {
- sg[nents - 1].length += bh->b_size;
- lastdataend += bh->b_size;
- continue;
- }
-
- /*
* start new segment
*/
if (nents >= PRD_ENTRIES)
--
Jens Axboe
next prev parent reply other threads:[~2002-09-11 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-11 12:48 [PATCH] highmem I/O for ide-pmac.c Paul Mackerras
2002-09-11 13:02 ` Jens Axboe
2002-09-11 13:07 ` Jens Axboe [this message]
2002-09-11 13:13 ` Jens Axboe
2002-09-11 18:53 ` Benjamin Herrenschmidt
2002-09-11 18:05 ` Jens Axboe
2002-09-12 6:54 ` Paul Mackerras
2002-09-12 6:59 ` Jens Axboe
2002-09-12 6:12 ` Paul Mackerras
2002-09-12 6:20 ` Jens Axboe
2002-09-12 5:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020911130754.GM1089@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.