All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Austin Gonyou <austin@coremetrics.com>
Cc: Christian Guggenberger 
	<christian.guggenberger@physik.uni-regensburg.de>,
	linux-kernel@vger.kernel.org, linux-xfs@oss.sgi.com
Subject: Re: 2.4.20pre5aa2
Date: Wed, 11 Sep 2002 20:41:11 +0200	[thread overview]
Message-ID: <20020911184111.GY17868@dualathlon.random> (raw)
In-Reply-To: <1031768655.24629.23.camel@UberGeek.coremetrics.com>

was a collision between new xfs and new scheduler, you can use this fix
in the meantime:

--- 2.4.20pre5aa3/fs/xfs/pagebuf/page_buf.c.~1~	Wed Sep 11 05:17:46 2002
+++ 2.4.20pre5aa3/fs/xfs/pagebuf/page_buf.c	Wed Sep 11 06:00:35 2002
@@ -2055,9 +2055,9 @@ pagebuf_iodone_daemon(
 	spin_unlock_irq(&current->sigmask_lock);
 
 	/* Migrate to the right CPU */
-	current->cpus_allowed = 1UL << cpu;
-	while (smp_processor_id() != cpu)
-		schedule();
+	set_cpus_allowed(current, 1UL << cpu);
+	if (cpu() != cpu)
+		BUG();
 
 	sprintf(current->comm, "pagebuf_io_CPU%d", bind_cpu);
 	INIT_LIST_HEAD(&pagebuf_iodone_tq[cpu]);

also remeber to apply the O_DIRECT fixes for reiserfs and ext3 (that
were left over after merging the new nfs stuff). all will be fixed in
next -aa of course.

--- 2.4.19pre3aa1/fs/reiserfs/inode.c.~1~	Tue Mar 12 00:07:18 2002
+++ 2.4.19pre3aa1/fs/reiserfs/inode.c	Tue Mar 12 01:24:21 2002
@@ -2161,10 +2161,11 @@
 	}
 }
 
-static int reiserfs_direct_io(int rw, struct inode *inode, 
+static int reiserfs_direct_io(int rw, struct file * filp,
                               struct kiobuf *iobuf, unsigned long blocknr,
 			      int blocksize) 
 {
+    struct inode * inode = filp->f_dentry->d_inode->i_mapping->host;
     return generic_direct_IO(rw, inode, iobuf, blocknr, blocksize,
                              reiserfs_get_block_direct_io) ;
 }
--- 2.4.20pre5aa2/fs/ext3/inode.c.~1~	Mon Sep  9 02:38:08 2002
+++ 2.4.20pre5aa2/fs/ext3/inode.c	Tue Sep 10 05:22:18 2002
@@ -1385,9 +1385,10 @@ static int ext3_releasepage(struct page 
 }
 
 static int
-ext3_direct_IO(int rw, struct inode *inode, struct kiobuf *iobuf,
+ext3_direct_IO(int rw, struct file * filp, struct kiobuf *iobuf,
 		unsigned long blocknr, int blocksize)
 {
+	struct inode * inode = filp->f_dentry->d_inode->i_mapping->host;
 	struct ext3_inode_info *ei = EXT3_I(inode);
 	handle_t *handle = NULL;
 	int ret;

Andrea

  parent reply	other threads:[~2002-09-11 18:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-11 18:16 2.4.20pre5aa2 Christian Guggenberger
2002-09-11 18:24 ` 2.4.20pre5aa2 Austin Gonyou
2002-09-11 18:28   ` 2.4.20pre5aa2 Christian Guggenberger
     [not found]     ` <1031769317.24629.28.camel@UberGeek.coremetrics.com>
2002-09-11 18:45       ` 2.4.20pre5aa2 Christian Guggenberger
2002-09-11 18:51         ` 2.4.20pre5aa2 Austin Gonyou
2002-09-11 18:41   ` Andrea Arcangeli [this message]
2002-09-12 23:29     ` 2.4.20pre5aa2 Samuel Flory
2002-09-12 23:45       ` 2.4.20pre5aa2 Stephen Lord
2002-09-13  0:06         ` 2.4.20pre5aa2 Samuel Flory
2002-09-13  0:23       ` 2.4.20pre5aa2 Andrea Arcangeli
2002-09-13  0:47         ` 2.4.20pre5aa2 Stephen Lord
2002-09-13  0:54           ` 2.4.20pre5aa2 Andrea Arcangeli
2002-09-13  2:14             ` 2.4.20pre5aa2 Samuel Flory
2002-09-13 12:53               ` 2.4.20pre5aa2 Andrea Arcangeli
2002-09-13 21:09                 ` 2.4.20pre5aa2 Samuel Flory
2002-09-13 21:18                   ` 2.4.20pre5aa2 Andrea Arcangeli
2002-09-14 14:39                     ` 2.4.20pre5aa2 Stephen Lord
2002-09-15 11:13                       ` 2.4.20pre5aa2 Andi Kleen
2002-09-15 19:39                         ` 2.4.20pre5aa2 Samuel Flory
2002-09-16 16:03                 ` 2.4.20pre5aa2 Dave Hansen
2002-09-16 16:20                   ` 2.4.20pre5aa2 Andrea Arcangeli
2002-09-16 16:39                     ` 2.4.20pre5aa2 Dave Hansen
2002-09-13  1:27           ` 2.4.20pre5aa2 Samuel Flory
2002-09-13  2:14             ` 2.4.20pre5aa2 Samuel Flory
2002-09-13  1:18         ` 2.4.20pre5aa2 Samuel Flory
2002-09-13 19:17           ` 2.4.20pre5aa2 Stephen Lord
2002-09-11 18:44 ` 2.4.20pre5aa2 Christoph Hellwig
2002-09-11 19:11   ` 2.4.20pre5aa2 Christian Guggenberger
  -- strict thread matches above, loose matches on Subject: below --
2002-09-09 16:50 2.4.20pre5aa2 Andrea Arcangeli
2002-09-10 18:51 ` 2.4.20pre5aa2 Joe Kellner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020911184111.GY17868@dualathlon.random \
    --to=andrea@suse.de \
    --cc=austin@coremetrics.com \
    --cc=christian.guggenberger@physik.uni-regensburg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.