Re: [PATCH] 10/10 sound/oss/dmasound/dmasound_q40.c

[Richard Zidlicky <rz@linux-m68k.org>]

On Thu, Aug 29, 2002 at 09:56:27PM +0200, pwaechtler@mac.com wrote:


> -static void Q40StereoInterrupt(int irq, void *dummy, struct pt_regs *fp)
> -{
> -        if (q40_sc>1){
> -            *DAC_LEFT=*q40_pp++;
> -	    *DAC_RIGHT=*q40_pp++;
> -	    q40_sc -=2;
> -	    master_outb(1,SAMPLE_CLEAR_REG);
> -	}else Q40Interrupt();
> -}
> -static void Q40MonoInterrupt(int irq, void *dummy, struct pt_regs *fp)

> +static void Q40InterruptHandler(int irq, void *dummy, struct pt_regs *fp)
> +{
> +	spin_lock(&dmasound.lock);
> +	if (q40_sc>1){
> +		if (dmasound.soft.stereo){
> +			*DAC_LEFT=*q40_pp++;
> +			*DAC_RIGHT=*q40_pp++;
> +			q40_sc -=2;
> +		} else {
> +			*DAC_LEFT=*q40_pp;
> +			*DAC_RIGHT=*q40_pp++;
> +			q40_sc --;
> +		}
>  	    master_outb(1,SAMPLE_CLEAR_REG);
>  	}else Q40Interrupt();
> +	spin_unlock(&dmasound.lock);
>  }
> +


not so good. The interrupt will happen up to 20000/s so any 
unneeded code in the interrupt handler like the test for stereo
should be avoided.. I will rewrite it in assembler someday.

Richard