Re: [PATCH 2/4] 2.4 SCSI error handling fixes

[Doug Ledford <dledford@redhat.com>]

On Thu, Sep 12, 2002 at 07:13:54PM +0100, Russell King wrote:
> -	scsi_setup_cmd_retry(SCpnt);
> -	scsi_send_eh_cmnd(SCpnt, SCpnt->timeout_per_command);
> +	do {
> +		scsi_setup_cmd_retry(SCpnt);
> +		scsi_send_eh_cmnd(SCpnt, SCpnt->timeout_per_command);
> +	} while (SCpnt->eh_state == NEEDS_RETRY);

> +		 * If the SCSI device responded with "logical unit
> +		 * is in process of becoming ready", we need to
> +		 * retry this command.
> +		 */
> +	} while (SCpnt->eh_state == NEEDS_RETRY);

> +		/*
> +		 * If the SCSI device responded with "logical unit
> +		 * is in process of becoming ready", we need to
> +		 * retry this command.
> +		 */
> +	} while (SCpnt->eh_state == NEEDS_RETRY);

>  		default:
> -			SCpnt->eh_state = FAILED;
> +			ret = FAILED;
> +			/*FALLTHROUGH*/
> +		case FAILED:
> +		case NEEDS_RETRY:
> +		case SUCCESS:
> +			SCpnt->eh_state = ret;
>  			break;
>  		}
>  	} else {

I don't see any bounding here.  You *have* to bound this.  It is not that 
uncommon for a device to report "logical unit is in the process of 
becoming ready" forever on certain types of hardware failures.  Without 
bounding, we won't ever give up on it.

-- 
  Doug Ledford <dledford@redhat.com>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606