All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: defouwj@purdue.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.0-2.5 bug in ip_options_compile
Date: Fri, 13 Sep 2002 15:13:06 -0700 (PDT)	[thread overview]
Message-ID: <20020913.151306.40776578.davem@redhat.com> (raw)
In-Reply-To: <20020913220838.GA1579@blorp.plorb.com>

   From: Jeff DeFouw <defouwj@purdue.edu>
   Date: Fri, 13 Sep 2002 17:08:38 -0500

   While reading about IP options, I found the IPOPT_END padding (cleaning)
   in ip_options_compile (net/ipv4/ip_options.c) was not incrementing a
   pointer.  There should be an optptr++ in the for end-of-block statement
   to go along with the l--, otherwise it's just comparing the same byte
   for each l.  Patch is against 2.4.19.  From the kernel source browser
   this bug is also in 2.5.31, 2.2.21, and 2.0.39.

Thanks a lot for spotting this, I will add this
to my 2.4.x and 2.5.x trees and merge upstream.

  reply	other threads:[~2002-09-13 22:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-13 22:08 [PATCH] 2.0-2.5 bug in ip_options_compile Jeff DeFouw
2002-09-13 22:13 ` David S. Miller [this message]
2002-09-13 22:50   ` David Weinehall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020913.151306.40776578.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=defouwj@purdue.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.