Re: ip_tables.h does not compile when using g++

[Harald Welte <laforge@gnumonks.org>]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

On Sat, Sep 14, 2002 at 12:07:22PM +0000, Scott Andrew Baillie wrote:
> The file linux-2.4.19/include/linux/netfilter_ipv4/ip_tables.h is
> included by user space programs as well as the kernel, hence I think
> that it should compile using g++.

You are right.

> This patch makes it compile. Patch is also attached.
> 
> 
> diff -ur linux-2.4.19/include/linux/netfilter_ipv4/ip_tables.h
> linux-2.4.19-new/include/linux/netfilter_ipv4/ip_tables.h
> --- linux-2.4.19/include/linux/netfilter_ipv4/ip_tables.h	Mon Feb 25
> 19:38:13 2002
> +++ linux-2.4.19-new/include/linux/netfilter_ipv4/ip_tables.h	Sat Sep 14
> 11:11:01 2002
> @@ -292,7 +292,7 @@
>  static __inline__ struct ipt_entry_target *
>  ipt_get_target(struct ipt_entry *e)
>  {
> -	return (void *)e + e->target_offset;
> +	return ((struct ipt_entry_target *)((char *)e + e->target_offset));

why does it have to be (char *) ? There are no characters involved, hence
it (in the spirit of this gcc extension) should be (void *).

The typecast to struct ipt_entry_target is correct, however.

Does it compile with 

	return ((struct ipt_entry_target *)((void *)e + e->target_offset));

If yes, I will submit this modified version of  your patch.

> Regards,
> Scott.



-- 
Live long and prosper
- Harald Welte / laforge@gnumonks.org               http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+ 
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]