From: Dipankar Sarma <dipankar@in.ibm.com>
To: Marc-Christian Petersen <m.c.p@wolk-project.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Read-Copy Update 2.5.36
Date: Thu, 19 Sep 2002 00:10:18 +0530 [thread overview]
Message-ID: <20020919001018.C23055@in.ibm.com> (raw)
In-Reply-To: <200209181937.39385.m.c.p@gmx.net>; from m.c.p@wolk-project.de on Wed, Sep 18, 2002 at 07:38:30PM +0200
On Wed, Sep 18, 2002 at 07:38:30PM +0200, Marc-Christian Petersen wrote:
> Hi Dipankar,
>
> > Here is RCU for 2.5.36. It is just a rediff from earlier version.
> unfortunately it does not build the modules correctly.
>
> Output of "make modules"
>
> make[1]: Entering directory `/usr/src/linux-2.5.36-vanilla/fs'
> gcc -Wp,-MD,./.binfmt_misc.o.d -D__KERNEL__
> -I/usr/src/linux-2.5.36-vanilla/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix include
> -DMODULE -DKBUILD_BASENAME=binfmt_misc -c -o binfmt_misc.o binfmt_misc.c
> In file included from /usr/src/linux-2.5.36-vanilla/include/linux/mm.h:4,
> from /usr/src/linux-2.5.36-vanilla/include/linux/pagemap.h:7,
> from binfmt_misc.c:26:
> /usr/src/linux-2.5.36-vanilla/include/linux/sched.h:480: parse error before
> `cpu_quiescent'
> /usr/src/linux-2.5.36-vanilla/include/linux/sched.h:480: warning: type
> defaults to `int' in declaration of `DEFINE_PER_CPU'
> /usr/src/linux-2.5.36-vanilla/include/linux/sched.h:480: warning: function
> declaration isn't a prototype
Ok, so DEFINE_PER_CPU() has now been excluded when MODULE is defined.
The included patch below should fix that.
Thanks
--
Dipankar Sarma <dipankar@in.ibm.com> http://lse.sourceforge.net
Linux Technology Center, IBM Software Lab, Bangalore, India.
--- linux-2.5.36-rcu_poll/include/linux/sched.h.orig Wed Sep 18 22:33:16 2002
+++ linux-2.5.36-rcu_poll/include/linux/sched.h Wed Sep 18 22:49:51 2002
@@ -477,7 +477,9 @@
extern struct mm_struct init_mm;
extern struct task_struct *init_tasks[NR_CPUS];
+#ifndef MODULE
extern DEFINE_PER_CPU(long, cpu_quiescent);
+#endif
/* PID hashing. (shouldnt this be dynamic?) */
#define PIDHASH_SZ 8192
@@ -1029,7 +1031,7 @@
#endif /* CONFIG_SMP */
-#ifdef CONFIG_PREEMPT
+#if defined(CONFIG_PREEMPT) && !defined(MODULE)
extern DEFINE_PER_CPU(atomic_t[2], rcu_preempt_cntr);
extern DEFINE_PER_CPU(atomic_t, *curr_preempt_cntr);
next prev parent reply other threads:[~2002-09-18 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 17:38 [PATCH] Read-Copy Update 2.5.36 Marc-Christian Petersen
2002-09-18 18:40 ` Dipankar Sarma [this message]
2002-09-18 19:03 ` Dipankar Sarma
2002-09-18 19:21 ` Marc-Christian Petersen
-- strict thread matches above, loose matches on Subject: below --
2002-09-18 12:42 Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020919001018.C23055@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.c.p@wolk-project.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.