From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] streq()
Date: Tue, 24 Sep 2002 14:49:41 +1000 [thread overview]
Message-ID: <20020924045313.0FBE52C075@lists.samba.org> (raw)
Embarrassing, huh? But I just found a bug in my code cause by
"if (strcmp(a,b))" instead of "if (!strcmp(a,b))".
This bites me about once a year, so Linus, please apply.
Preparing to have my "3l33t k3rN31 h@ck3r" card revoked,
Rusty.
Name: streq implementation
Author: Rusty Russell
Status: Trivial
D: I can't believe that after all these years I still make the "sense
D: of strcmp" mistake. So it's time to reintroduce my favorite macro.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.38/include/linux/string.h working-2.5.38-streq/include/linux/string.h
--- linux-2.5.38/include/linux/string.h 2002-06-06 21:38:40.000000000 +1000
+++ working-2.5.38-streq/include/linux/string.h 2002-09-24 14:43:30.000000000 +1000
@@ -15,7 +15,7 @@ extern "C" {
extern char * strpbrk(const char *,const char *);
extern char * strsep(char **,const char *);
extern __kernel_size_t strspn(const char *,const char *);
-
+#define streq(a,b) (strcmp((a),(b)) == 0)
/*
* Include machine specific inline routines
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next reply other threads:[~2002-09-24 4:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 4:49 Rusty Russell [this message]
2002-09-24 5:40 ` [PATCH] streq() Ingo Molnar
2002-09-24 6:04 ` Rusty Russell
2002-09-24 6:24 ` David S. Miller
2002-09-24 7:28 ` Rusty Russell
2002-09-24 7:38 ` Ingo Molnar
2002-09-24 8:19 ` David S. Miller
2002-09-24 13:07 ` Denis Vlasenko
2002-09-24 17:21 ` H. Peter Anvin
2002-09-25 11:27 ` Daniel Egger
2002-09-25 11:45 ` Russell King
2002-09-25 12:38 ` Daniel Egger
2002-09-25 12:19 ` Michael Sinz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020924045313.0FBE52C075@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.