From: Pete Zaitcev <zaitcev@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
andre@linux-ide.org, linux-kernel@vger.kernel.org, axboe@suse.de,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] fix ide-iops for big endian archs
Date: Wed, 25 Sep 2002 14:19:46 -0400 [thread overview]
Message-ID: <20020925141946.A14230@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1032957359.10217.linux-kernel2news@redhat.com>; from zaitcev@redhat.com on Wed, Sep 25, 2002 at 02:32:23PM +0200
> From: "Benjamin Herrenschmidt" <benh@kernel.crashing.org>
> Date: Wed, 25 Sep 2002 14:32:23 +0200
> Curently in 2.5 (afaik in -ac too), the ide-iops "s" routines used
> to transfer datas in/out the data port are incorrect for big endian
> machines. They are implemented with a loop of inw/outw which are
> byteswapping, but a fifo transfer like that mustn't be swapped.
Dunno about ppc, but sparc works just fine as it is in 2.4.
When was the last time you examined include/asm-sparc/ide.h?
IDE uses ide_insw instead of plain insw specifically to
resolve this kind of issue, and you are trying to defeat
the mechanism designed to help you. I smell a fish here.
-- Pete
next parent reply other threads:[~2002-09-25 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1032957359.10217.linux-kernel2news@redhat.com>
2002-09-25 18:19 ` Pete Zaitcev [this message]
2002-09-25 19:57 ` [PATCH] fix ide-iops for big endian archs David S. Miller
2002-09-25 22:49 ` Benjamin Herrenschmidt
2002-09-25 22:48 ` Benjamin Herrenschmidt
2002-09-25 12:32 Benjamin Herrenschmidt
2002-09-25 18:22 ` Linus Torvalds
2002-09-25 22:44 ` Benjamin Herrenschmidt
2002-09-26 15:11 ` Alan Cox
2002-09-26 15:16 ` Benjamin Herrenschmidt
2002-09-26 16:04 ` Benjamin Herrenschmidt
2002-09-26 15:09 ` Alan Cox
2002-09-26 15:14 ` Benjamin Herrenschmidt
2002-09-26 20:58 ` Richard Zidlicky
2002-09-26 21:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020925141946.A14230@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.