All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Björn Stenberg" <bjorn@haxx.se>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Meelis Roos <mroos@linux.ee>,
	linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: PPC: unresolved module symbols in 2.4.20-pre7+bk
Date: Thu, 26 Sep 2002 17:59:09 +0200	[thread overview]
Message-ID: <20020926175909.E11535@linux3.contactor.se> (raw)
In-Reply-To: <20020926142927.GE5746@opus.bloom.county>; from trini@kernel.crashing.org on Thu, Sep 26, 2002 at 07:29:27AM -0700

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Tom Rini wrote:
> > > > depmod: *** Unresolved symbols in /lib/modules/2.4.20-pre7/kernel/drivers/usb/storage/usb-storage.o
> > > > depmod: 	ppc_generic_ide_fix_driveid
> 
> Configuration issue.  CONFIG_USB_STORAGE_ISD200 needs to depend on
> CONFIG_IDE, since it calls ide_fixup_driveid().  Greg? Björn?

This is only an issue for PPC and SPARC64. Other targets have an empty macro for ide_fix_driveid().

I don't know how this kind of "target-dependent dependency" is normally handled. The attached patch is one way.

-- 
Björn

[-- Attachment #2: Config.in-isd200.patch --]
[-- Type: text/plain, Size: 1289 bytes --]

--- linux-2.4.20-pre7/drivers/usb/Config.in~	2002-09-26 17:04:18.000000000 +0200
+++ linux-2.4.20-pre7/drivers/usb/Config.in	2002-09-26 17:41:06.000000000 +0200
@@ -41,7 +41,11 @@
       dep_mbool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG $CONFIG_USB_STORAGE
       dep_mbool '    Datafab MDCFE-B Compact Flash Reader support' CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM  $CONFIG_USB_STORAGE
-      dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE
+      if [ "$CONFIG_PPC" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
+         dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE $CONFIG_IDE
+      else
+         dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE
+      fi
       dep_mbool '    Microtech CompactFlash/SmartMedia support' CONFIG_USB_STORAGE_DPCM $CONFIG_USB_STORAGE
       dep_mbool '    HP CD-Writer 82xx support' CONFIG_USB_STORAGE_HP8200e $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    SanDisk SDDR-09 (and other SmartMedia) support' CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL

  reply	other threads:[~2002-09-26 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-24 19:18 PPC: unresolved module symbols in 2.4.20-pre7+bk Meelis Roos
2002-09-24 23:48 ` Tom Rini
2002-09-26  8:31   ` Meelis Roos
2002-09-26 14:29     ` Tom Rini
2002-09-26 15:59       ` Björn Stenberg [this message]
2002-09-26 16:08         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020926175909.E11535@linux3.contactor.se \
    --to=bjorn@haxx.se \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.