From: Christoph Hellwig <hch@sgi.com>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix drm ioctl ABI default
Date: Fri, 27 Sep 2002 21:27:52 -0400 [thread overview]
Message-ID: <20020927212752.E4733@sgi.com> (raw)
Add a config option to make the i810 drm ioctl ABI XFree4.1 compatible
by default (currently that's a module parameter). The XFree folks fucked
this up by adding members in the middle of a struct and we have to work
around it now. At least we should have the pre-2.4.20 behaviour as default.
(And I'd suggest you add that option as y to the defconfig)
--- linux-2.4.20-pre5/drivers/char/drm/Config.in Thu Aug 29 02:58:43 2002
+++ linux/drivers/char/drm/Config.in Fri Sep 6 21:19:07 2002
@@ -10,6 +10,7 @@ tristate ' 3dfx Banshee/Voodoo3+' CONFI
tristate ' ATI Rage 128' CONFIG_DRM_R128
dep_tristate ' ATI Radeon' CONFIG_DRM_RADEON $CONFIG_AGP
dep_tristate ' Intel I810' CONFIG_DRM_I810 $CONFIG_AGP
+dep_mbool ' Enabled XFree 4.1 ioctl interface by default' CONFIG_DRM_I810_XFREE_41 $CONFIG_DRM_I810
dep_tristate ' Intel 830M' CONFIG_DRM_I830 $CONFIG_AGP
dep_tristate ' Matrox g200/g400' CONFIG_DRM_MGA $CONFIG_AGP
dep_tristate ' SiS' CONFIG_DRM_SIS $CONFIG_AGP
--- linux-2.4.20-pre5/drivers/char/drm/i810_dma.c Thu Aug 29 02:58:43 2002
+++ linux/drivers/char/drm/i810_dma.c Fri Sep 6 21:18:07 2002
@@ -30,6 +30,7 @@
*
*/
+#include <linux/config.h>
#include "i810.h"
#include "drmP.h"
#include "i810_drv.h"
@@ -466,8 +467,11 @@ static int i810_dma_initialize(drm_devic
return 0;
}
-
+#ifdef CONFIG_DRM_I810_XFREE_41
+int xfreeversion = 41;
+#else
int xfreeversion = -1;
+#endif
MODULE_PARM(xfreeversion, "i");
MODULE_PARM_DESC(xfreeversion, "The version of XFree86 that needs to be supported");
next reply other threads:[~2002-09-27 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-28 1:27 Christoph Hellwig [this message]
2002-09-27 19:07 ` [PATCH] fix drm ioctl ABI default Alan Cox
2002-09-27 19:13 ` Ben Collins
2002-09-27 20:06 ` Alan Cox
2002-09-28 2:21 ` Christoph Hellwig
2002-09-27 20:04 ` Alan Cox
2002-09-29 20:33 ` Adrian Bunk
2002-09-29 20:43 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020927212752.E4733@sgi.com \
--to=hch@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.