From: David Gibson <david@gibson.dropbear.id.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Orinoco Development List <orinoco-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Orinoco-devel] Re: Orinoco driver update
Date: Mon, 30 Sep 2002 16:22:43 +1000 [thread overview]
Message-ID: <20020930062243.GH10265@zax> (raw)
In-Reply-To: <3D97E30E.50703@pobox.com>
On Mon, Sep 30, 2002 at 01:37:18AM -0400, Jeff Garzik wrote:
> David,
>
> Linus applied 0.13a and that fixes things, thanks.
>
> Two quick comments:
> * you need pci_set_drvdata(pdev,NULL) after pci_disable_disable in your
> pci_driver::remove hook
Ok, I've added that before kfree()ing the net_device structure in both
orinoco_pci.c and orinoco_plx.c
> * I think it would look better to remove the struct pci_driver ->suspend
> and ->resume hook references, if they are NULL (0)...
Hmm... I'd kind of prefer to leave them there, to remind me that the
suspend/resume hooks need to be implemented.
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2002-09-30 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020927025227.GC1898@zax>
2002-09-27 19:56 ` Orinoco driver update Jeff Garzik
2002-09-30 5:08 ` [Orinoco-devel] " David Gibson
2002-09-30 5:37 ` Jeff Garzik
2002-09-30 6:22 ` David Gibson [this message]
2002-09-30 6:34 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020930062243.GH10265@zax \
--to=david@gibson.dropbear.id.au \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.