From: Dave Jones <davej@codemonkey.org.uk>
To: Art Haas <ahaas@neosoft.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3
Date: Tue, 1 Oct 2002 16:24:28 +0100 [thread overview]
Message-ID: <20021001152428.GB126@suse.de> (raw)
In-Reply-To: <20021001004432.GA4230@debian>
On Mon, Sep 30, 2002 at 07:44:32PM -0500, Art Haas wrote:
> --- linux-2.4.20-pre8-ac3/mm/vmalloc.c.ac3 2002-09-30 18:27:42.000000000 -0500
> +++ linux-2.4.20-pre8-ac3/mm/vmalloc.c 2002-09-30 13:59:30.000000000 -0500
> @@ -179,7 +179,7 @@
>
> size += PAGE_SIZE;
> if (!size) {
> - kfree (addr);
> + kfree (area);
> return NULL;
> }
Ick, that's my bad. Fix is correct, though davem suggested testing
for -PAGE_SIZE before we do the kmalloc would be cleaner.
I tend to agree, but didn't get around to doing it.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
prev parent reply other threads:[~2002-10-01 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-01 0:44 [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3 Art Haas
2002-10-01 15:24 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021001152428.GB126@suse.de \
--to=davej@codemonkey.org.uk \
--cc=ahaas@neosoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.