All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] pcibios_* removals for 2.5.40
Date: Fri, 4 Oct 2002 09:59:55 -0700	[thread overview]
Message-ID: <20021004165955.GC6978@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210040930581.1723-100000@home.transmeta.com>

On Fri, Oct 04, 2002 at 09:33:08AM -0700, Linus Torvalds wrote:
> 
> On Thu, 3 Oct 2002, Greg KH wrote:
> > 
> > Here's some changesets that remove the pcibios_find_class(),
> > pci_find_device(), and pcibios_present() functions.  These functions
> > have been marked as obsolete since the 2.2 kernel, so it's about time
> > that we removed them.
> 
> They are still in use by a lot of drivers..

Not all that many drivers:

pcibios_find_class is used in the following files:
 	drivers/net/aironet4500_card.c
	drivers/net/wan/lmc/lmc_main.c

The lmc driver has only had 1 janitor cleanup in all of 2.5, and the
aironet4500_card driver has had only trivial changes too.  But I'll try
to fix them up, if anyone uses them, and I break them, I'm sure I'll
hear about it :)

pcibios_find_device is used in only 11 different drivers.  I'll go clean
up those instances too.

And I thought I caught all of the places that pcibios_present() was used
already, but I'll go verify that again.

> I hate to break even more drivers at this point in 2.5.x, and so quite
> frankly I'd rather just do this in early 2.7.x instead. Unless
> somebody really steps up to the plate and also fixes the drivers
> ("it's a ton of fun, and imagine all the adoration you'll get from
> teenage girls/boys/ninja turtles for doing it")

I'll clean them all up and resubmit these changes to you when finished.

thanks,

greg k-h
(who can't wait for the ninja turtles to finally start adoring him!)

  parent reply	other threads:[~2002-10-04 16:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-03 22:40 [BK PATCH] pcibios_* removals for 2.5.40 Greg KH
2002-10-03 22:40 ` Greg KH
2002-10-03 22:41   ` Greg KH
2002-10-03 22:41     ` Greg KH
2002-10-04 16:33 ` Linus Torvalds
2002-10-04 16:53   ` Alan Cox
2002-10-04 17:30     ` Linus Torvalds
2002-10-04 18:01       ` Greg KH
2002-10-04 16:59   ` Greg KH [this message]
2002-10-04 17:28     ` Alan Cox
2002-10-04 18:07       ` Arnaldo Carvalho de Melo
2002-10-04 20:51     ` Greg KH
2002-10-04 20:52       ` Greg KH
2002-10-04 20:53         ` Greg KH
2002-10-04 20:54           ` Greg KH
2002-10-04 21:34             ` Jeff Garzik
2002-10-04 21:52               ` Greg KH
2002-10-04 21:36           ` Jeff Garzik
2002-10-04 21:40         ` Jeff Garzik
2002-10-04 21:53           ` Greg KH
2002-10-04 22:14             ` Russell King
2002-10-04 18:03   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004165955.GC6978@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.