All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Carlos E Gorges <carlos@techlinux.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.40 - DMA-mapping && misc
Date: Fri, 4 Oct 2002 18:59:02 +0100	[thread overview]
Message-ID: <20021004185902.G18545@parcelfarce.linux.theplanet.co.uk> (raw)


- virt_to_bus(((struct scatterlist *)cmd->buffer)[i].address) :
+ virt_to_bus(
+ page_address(((struct scatterlist *)cmd->buffer)[i].page) +
+ ((struct scatterlist *)cmd->buffer)[i].offset ) :
             virt_to_bus(cmd->request_buffer);

have you actually read Documentation/DMA-mapping.txt?  It says quite plainly:

Drivers converted fully to this interface should not use virt_to_bus any
longer, nor should they use bus_to_virt. 
[...]
It is planned to completely remove virt_to_bus() and bus_to_virt() as
they are entirely deprecated.

So, your patch is quite insufficient.

-- 
Revolutions do not require corporate support.

             reply	other threads:[~2002-10-04 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-04 17:59 Matthew Wilcox [this message]
     [not found] <mailman.1033712580.28994.linux-kernel2news@redhat.com>
2002-10-04 19:54 ` [PATCH] 2.5.40 - DMA-mapping && misc Pete Zaitcev
  -- strict thread matches above, loose matches on Subject: below --
2002-10-04  6:19 Carlos E Gorges

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004185902.G18545@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=carlos@techlinux.com.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.