From: Andi Kleen <ak@muc.de>
To: "Matt D. Robinson" <yakker@aparity.com>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols
Date: Sat, 5 Oct 2002 03:33:40 +0200 [thread overview]
Message-ID: <20021005013340.GA11802@averell> (raw)
In-Reply-To: <Pine.LNX.4.44.0210041822120.10168-100000@nakedeye.aparity.com>
On Sat, Oct 05, 2002 at 03:25:24AM +0200, Matt D. Robinson wrote:
> On 5 Oct 2002, Andi Kleen wrote:
> |>"Matt D. Robinson" <yakker@aparity.com> writes:
> |>
> |>> diff -urN -X /home/bharata/dontdiff linux-2.5.40/arch/i386/kernel/i386_ksyms.c linux-2.5.40+lkcd/arch/i386/kernel/i386_ksyms.c
> |>> --- linux-2.5.40/arch/i386/kernel/i386_ksyms.c Tue Oct 1 12:36:59 2002
> |>> +#if defined(CONFIG_X86) || defined(CONFIG_ALPHA)
> |>> +EXPORT_SYMBOL(page_is_ram);
> |>> +#endif
> |>
> |>This ifdef in i386_ksyms.c doesn't make much sense...
>
> If the rest of the architectures used page_is_ram(), this
> wouldn't be a problem, but not all do. And since we use
> it/need it, that's the reason for the addition.
My point was that in i386_ksyms you are always on i386 and never on alpha.
So you can just remove that #ifdef.
-Andi
prev parent reply other threads:[~2002-10-05 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 23:03 [PATCH] 2.5.40: lkcd (4/9): additional kernel symbols Matt D. Robinson
2002-10-05 0:11 ` Andi Kleen
2002-10-05 1:25 ` Matt D. Robinson
2002-10-05 1:33 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021005013340.GA11802@averell \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yakker@aparity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.