From: Ben Collins <bcollins@debian.org>
To: Andrew Patrikalakis <anrp@irulethe.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PowerPC] Bug in IEEE1394 implementation on PowerBooks [Patch address]
Date: Sun, 6 Oct 2002 09:07:52 -0400 [thread overview]
Message-ID: <20021006130752.GF566@phunnypharm.org> (raw)
In-Reply-To: <20021006042003.4ED2F95E7F@irulethe.net>
On Sat, Oct 05, 2002 at 09:20:03PM -0700, Andrew Patrikalakis wrote:
>
> Hello again,
>
> Since this is my first Linux patch, I'm not sure
> if what it does is OK, or even possible (but it
> works for me).
>
> As this is kind of a specialist thing (FireWire
> on Apple laptops with Linux) I decided to put the
> patch on a web page:
> http://anrp.irulethe.net/powerbook-ieee1394.html
>
> Anyone with this setup (Apple Pbook + firewire)
> please test this patch.
Checked your patch, but there are several problems with it.
For one, it only takes into account one OHCI1394 card being installed.
You'd be better of iterating over a list of all cards rather than
hardcoding one card, but that's moot given point 2.
Secondly, it seems that the problem doesn't really lie in ohci1394, but
that it actually has to do with the disk layer. From other usages of the
pmu interface, it seems that your best example is in drivers/scsi/mesh.c
and the change should be applied to sbp2.c.
If you need further help, you may want to talk to BenH (ppc maintainer).
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo - http://www.deqo.com/
prev parent reply other threads:[~2002-10-06 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 4:20 [PowerPC] Bug in IEEE1394 implementation on PowerBooks [Patch address] Andrew Patrikalakis
2002-10-06 13:07 ` Ben Collins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021006130752.GF566@phunnypharm.org \
--to=bcollins@debian.org \
--cc=anrp@irulethe.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.