From: Vojtech Pavlik <vojtech@suse.cz>
To: jbradford@dial.pipex.com
Cc: Vojtech Pavlik <vojtech@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.X breaks PS/2 mouse
Date: Mon, 7 Oct 2002 16:23:18 +0200 [thread overview]
Message-ID: <20021007162318.A758@ucw.cz> (raw)
In-Reply-To: <200210071417.g97EHDjG006197@darkstar.example.net>; from jbradford@dial.pipex.com on Mon, Oct 07, 2002 at 03:17:13PM +0100
On Mon, Oct 07, 2002 at 03:17:13PM +0100, jbradford@dial.pipex.com wrote:
> I didn't, but I've compiled a new kernel with it in. Unfortunately, it doesn't seem to do anything useful :-(.
>
> cat /dev/input/eventX | hexdump
>
> returns nothing, not even for keyboard events, which makes me think I've gone wrong somewhere :-/
Have you tried all of them (0, 1, 2 ...)? Btw, you can compile evbug in
also.
> > If it was different, then definitely!
>
> Sorry, I was wrong, I think I pressed a mouse button whilst connecting it and mis-read the info. The init is exactly the same.
>
> However, the data sent from each one seems to be very different, (I've re-formatted this a bit to save space, but it's from the dmesg output):
>
> mouse
>
> Left button - 09 00 00 08 00 00
> Right button - 0a 00 00 08 00 00
>
> trackball
>
> Left button - 01 00 00 00 00 00
> Right button - 02 00 00 00 00 00
Hmm, interesting ... let's see what that means ...
Indeed the 0x08 byte indicates the beginning of a packet. The driver
synchronizes on that, and when it's missing, it ignores the packets.
Thus, it ignores all the packets from the trackball.
This patch should fix that:
===================================================================
diff -Nru a/drivers/input/mouse/psmouse.c b/drivers/input/mouse/psmouse.c
--- a/drivers/input/mouse/psmouse.c Mon Oct 7 16:22:53 2002
+++ b/drivers/input/mouse/psmouse.c Mon Oct 7 16:22:53 2002
@@ -201,7 +201,7 @@
psmouse->packet[psmouse->pktcnt++] = data;
if (psmouse->pktcnt == 3 + (psmouse->type >= PSMOUSE_GENPS)) {
- if ((psmouse->packet[0] & 0x08) == 0x08) psmouse_process_packet(psmouse);
+ psmouse_process_packet(psmouse);
psmouse->pktcnt = 0;
return;
}
===================================================================
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-10-07 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 20:20 2.5.X breaks PS/2 mouse jbradford
2002-10-04 20:15 ` Vojtech Pavlik
2002-10-04 20:52 ` jbradford
2002-10-04 20:45 ` Vojtech Pavlik
2002-10-04 21:01 ` jbradford
2002-10-04 22:25 ` jbradford
2002-10-07 12:09 ` Vojtech Pavlik
2002-10-07 12:46 ` jbradford
2002-10-07 12:42 ` Vojtech Pavlik
2002-10-07 14:17 ` jbradford
2002-10-07 14:23 ` Vojtech Pavlik [this message]
2002-10-07 20:15 ` jbradford
2002-10-07 20:08 ` Vojtech Pavlik
2002-10-07 23:47 ` Thomas Molina
2002-10-07 15:25 ` [FUNNY] " jbradford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021007162318.A758@ucw.cz \
--to=vojtech@suse.cz \
--cc=jbradford@dial.pipex.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.