From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] [RFC] [PATCH 2/4] Add extended attributes to ext2/3
Date: Tue, 8 Oct 2002 14:45:34 -0400 [thread overview]
Message-ID: <20021008184534.GB8174@think.thunk.org> (raw)
In-Reply-To: <20021008192306.B12912@infradead.org>
On Tue, Oct 08, 2002 at 07:23:06PM +0100, Christoph Hellwig wrote:
>
> The code doesn't really make ?ny sense outside ext2/ext3. I'd suggest you
> move it there instead of bloating every kernel with it unconditionally.
The code is general enough that it can be used for a variety of
purposes, not just ext2/ext3, although granted at the moment only ext2
and ext3 are using it. Also, having two copies of the code bewteen
the ext2 and ext3 directories is undeseriable.
Probably the right thing to do is to add the appropriate logic in
fs/Config.in so it's only enabled when necessary.
>
> __mb_cache_entry_in_lru() is buggy and can't work anymore now that akpm removed
> some list_head debugging.
Oops. Nice catche. I didn't notice since it's only used in the
mb_assert code, which I hadn't enabled.
> And please get rid of the LINUX_VERSION_CODE checks..
Thanks. Missed those....
- Ted
prev parent reply other threads:[~2002-10-08 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-08 18:08 [RFC] [PATCH 2/4] Add extended attributes to ext2/3 tytso
2002-10-08 18:23 ` [Ext2-devel] " Christoph Hellwig
2002-10-08 18:45 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021008184534.GB8174@think.thunk.org \
--to=tytso@mit.edu \
--cc=ext2-devel@lists.sourceforge.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.