All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] [RFC] [PATCH 3/4] Add extended attributes to ext2/3
Date: Tue, 8 Oct 2002 18:21:40 -0400	[thread overview]
Message-ID: <20021008222140.GB9842@think.thunk.org> (raw)
In-Reply-To: <20021008195322.A14585@infradead.org>

On Tue, Oct 08, 2002 at 07:53:22PM +0100, Christoph Hellwig wrote:
> 
> Also please get rid of the registration API for xattr handlers - this
> is inside a single module so hardconding them in the inode operations
> won't hurt.  the additional lock for the registration OTOH may hurt and
> it looks really overengineered.

The registration API is also used for the ACL routines.  That's why
it's there.

That being said, I'm not at all convinced that allowing things like
the EA routines and the ACL routines to be separate modules is a good
idea.  Life would be much simpler if everything was compiled into a
single ext3 subsystem, and we eliminate all of the extra overhead of
having separate modules for specific filesystem features.  Certainly
the XFS and JFS folks didn't go down this path.

(That's why I took out to the questions in Config.in; I really felt
that it was wrong.  I however didn't want to go as far as to remove
the #ifdef's and removing the registration API's without at least
having some discussion on the topic.)

						- Ted

  parent reply	other threads:[~2002-10-08 22:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-08 18:08 [RFC] [PATCH 3/4] Add extended attributes to ext2/3 tytso
2002-10-08 18:53 ` [Ext2-devel] " Christoph Hellwig
2002-10-08 19:14   ` Andreas Gruenbacher
2002-10-08 19:20     ` Christoph Hellwig
2002-10-08 20:41       ` Stephen C. Tweedie
2002-10-08 20:47         ` Christoph Hellwig
2002-10-08 21:19           ` Andreas Dilger
2002-10-08 22:17         ` Theodore Ts'o
2002-10-09 11:29           ` Andreas Gruenbacher
2002-10-09 15:25             ` Stephen C. Tweedie
2002-10-08 22:21   ` Theodore Ts'o [this message]
     [not found]     ` <20021009064242.GW3045@clusterfs.com>
2002-10-09 13:09       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021008222140.GB9842@think.thunk.org \
    --to=tytso@mit.edu \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.