From: James Bottomley <James.Bottomley@steeleye.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: Degraded I/O performance, since 2.5.41
Date: Thu, 10 Oct 2002 18:09:14 -0700 [thread overview]
Message-ID: <200210110109.g9B19FJ14530@localhost.localdomain> (raw)
In-Reply-To: Message from Dave Hansen <haveblue@us.ibm.com> of "Thu, 10 Oct 2002 16:48:47 PDT." <3DA611DF.3000206@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
OK, this patch should fix it. Do your performance numbers for ips improve
again with this?
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 687 bytes --]
===== drivers/scsi/scsi_scan.c 1.24 vs edited =====
--- 1.24/drivers/scsi/scsi_scan.c Tue Oct 8 15:45:57 2002
+++ edited/drivers/scsi/scsi_scan.c Thu Oct 10 17:40:53 2002
@@ -1477,11 +1477,14 @@
if (sdt->detect)
sdev->attached += (*sdt->detect) (sdev);
- if (sdev->host->hostt->slave_attach != NULL)
+ if (sdev->host->hostt->slave_attach != NULL) {
if (sdev->host->hostt->slave_attach(sdev) != 0) {
printk(KERN_INFO "scsi_add_lun: failed low level driver attach, setting device offline");
sdev->online = FALSE;
}
+ } else if(sdev->host->cmd_per_lun) {
+ scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
+ }
if (sdevnew != NULL)
*sdevnew = sdev;
next prev parent reply other threads:[~2002-10-11 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0210092015170.9790-100000@home.transmeta.com>
2002-10-10 23:48 ` Degraded I/O performance, since 2.5.41 Dave Hansen
2002-10-10 23:54 ` James Bottomley
2002-10-11 1:09 ` James Bottomley [this message]
2002-10-11 1:59 ` Doug Ledford
2002-10-17 5:52 ` block TCQ [was: Re: Degraded I/O performance, since 2.5.41] Luben Tuikov
[not found] ` <3DA61041.9080808@us.ibm.com>
[not found] ` <20021011004227.GA27073@redhat.com>
2002-10-11 0:53 ` Degraded I/O performance, since 2.5.41 Dave Hansen
2002-10-11 1:45 ` Dave Hansen
2002-10-11 13:49 Jeffery, David
2002-10-12 17:47 ` Mike Anderson
-- strict thread matches above, loose matches on Subject: below --
2002-10-10 1:09 Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210110109.g9B19FJ14530@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=haveblue@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.