From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Art Haas <ahaas@neosoft.com>
Cc: Jens Axboe <axboe@suse.de>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] C99 designated initializers for drivers/scsi
Date: Sat, 12 Oct 2002 14:42:40 -0300 [thread overview]
Message-ID: <20021012174240.GA5259@conectiva.com.br> (raw)
In-Reply-To: <20021012165901.GK633@debian>
Em Sat, Oct 12, 2002 at 11:59:01AM -0500, Art Haas escreveu:
>
> Art Haas
>
> --- linux-2.5.42/drivers/scsi/ide-scsi.c.old 2002-10-12 09:46:55.000000000 -0500
> +++ linux-2.5.42/drivers/scsi/ide-scsi.c 2002-10-12 09:51:32.000000000 -0500
> @@ -574,29 +574,29 @@
> * IDE subdriver functions, registered with ide.c
> */
> static ide_driver_t idescsi_driver = {
> + .busy = 0,
> + .supports_dsc_overlap = 0,
> + .standby = NULL,
> + .flushcache = NULL,
> + .media_change = NULL,
> + .revalidate = NULL,
> + .pre_reset = NULL,
> + .capacity = NULL,
> + .special = NULL,
> + .proc = NULL,
Art, I suggest that you simply delete the lines that initializes to 0 or NULL,
as the compiler will take care of zeroing it and the source code gets a bit
smaller.
- Arnaldo
prev parent reply other threads:[~2002-10-12 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-12 16:59 [PATCH] C99 designated initializers for drivers/scsi Art Haas
2002-10-12 17:42 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021012174240.GA5259@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=ahaas@neosoft.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.