All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dipankar Sarma <dipankar@in.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@digeo.com>, Ingo Molnar <mingo@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Structure clobbering causes timer oopses
Date: Mon, 14 Oct 2002 01:20:12 +0530	[thread overview]
Message-ID: <20021014012012.A13906@in.ibm.com> (raw)
In-Reply-To: <3DA8D5E6.8090201@us.ibm.com>; from haveblue@us.ibm.com on Sun, Oct 13, 2002 at 02:17:46AM +0000

On Sun, Oct 13, 2002 at 02:17:46AM +0000, Dave Hansen wrote:
> > If they're initially using add_timer(), that works out
> > OK.  It they start out using mod_timer() (or del_timer) then bug.
> 
> The init_timer() comment says otherwise, but I imagine that not using 
> it shouldn't _cause_ any bugs.
> 
> * init_timer() must be done to a timer prior calling *any* of the
> * other timer functions.

I am not sure about that. init_timer() initializes timer->base
and timer_pending() checks for base == NULL. So, it is illegal
to do timer_pending(), mod_timer() and del_timer*() without an
init_timer() or an add_timer() earlier. But then, I presume this
was a requirement in the earlier timer interfaces too. No ?

Thanks
-- 
Dipankar Sarma  <dipankar@in.ibm.com> http://lse.sourceforge.net
Linux Technology Center, IBM Software Lab, Bangalore, India.

      reply	other threads:[~2002-10-13 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-13  0:59 Structure clobbering causes timer oopses Dave Hansen
2002-10-13  1:07 ` Andrew Morton
2002-10-13  2:09   ` Dave Hansen
2002-10-13 19:50     ` Dipankar Sarma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021014012012.A13906@in.ibm.com \
    --to=dipankar@in.ibm.com \
    --cc=akpm@digeo.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.