All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: Add extended attributes to ext2/3
Date: Tue, 15 Oct 2002 14:29:43 -0400	[thread overview]
Message-ID: <20021015182943.GA1335@think.thunk.org> (raw)
In-Reply-To: <200210151640.15581.agruen@suse.de>

On Tue, Oct 15, 2002 at 04:40:15PM +0200, Andreas Gruenbacher wrote:
> Hello,
> 
> Here are two fixes as incrementals to the xattr/acl patches:
> 
> fix-xattr.diff: The bad_block bug Andreas Dilger has reported

I've fixed this already in my patches, thanks.

> fix-acl.diff: Make change in ext[23]_new_inode() less intrusive.

Uh, I must be missing something.

It looks like the ext3 change in fix-acl.diff was to revert a change
that I never had; it's not in the 2.4 0.8.50 patches, and it wasn't in
my patches.  So I'm not sure what's going on there.

The ext2 change in fix-acl.diff looks *wrong*.  It removes a call to
mark_inode_dirty which was there in the original, and which is
necessary.

Are you sure you sent me the right diff, or that you diffed the
correct set of trees/files?

						- Ted

  reply	other threads:[~2002-10-15 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 14:40 Add extended attributes to ext2/3 Andreas Gruenbacher
2002-10-15 18:29 ` Theodore Ts'o [this message]
2002-10-15 21:00   ` Andreas Gruenbacher
2002-10-15 22:01     ` Andreas Dilger
2002-10-15 22:09       ` Andreas Gruenbacher
2002-10-15 22:18         ` Andreas Gruenbacher
2002-10-21 10:48       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021015182943.GA1335@think.thunk.org \
    --to=tytso@mit.edu \
    --cc=agruen@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.