All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Crispin Cowan <crispin@wirex.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make LSM register functions GPLonly exports
Date: Thu, 17 Oct 2002 10:20:05 -0700	[thread overview]
Message-ID: <20021017172005.GE31464@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210170958340.6739-100000@home.transmeta.com>

On Thu, Oct 17, 2002 at 10:08:19AM -0700, Linus Torvalds wrote:
> 
> Note that if this fight ends up being a major issue, I'm just going to 
> remove LSM and let the security vendors do their own thing. So far
> 
>  - I have not seen a lot of actual usage of the hooks

The SELinux module uses almost every hook so far.  A number of companies
and distros are currently auditing this module, and it will probably be
submitted for inclusion into the main kernel tree after they are
finished.

>  - seen a number of people who still worry that the hooks degrade 
>    performance in critical areas

I have a set of patches to send you today that will solve that problem,
by allowing people who do not want the hook to compile them away into
nothingness.  DaveM agrees with the proposed way of doing this.

>  - the worry that people use it for non-GPL'd modules is apparently real, 
>    considering Crispin's reply.

I agree with this, and argue to mark the functions as
EXPORT_SYMBOL_GPL() to make some people feel a bit more warm and fuzzy
that these hooks will not be co-oped for non-GPL use (this includes me.)

In short, I like Christoph's patch.

> I will re-iterate my stance on the GPL and kernel modules:

Thank you for posting this.  I know a lot of people appreciate it.

greg k-h

  reply	other threads:[~2002-10-17 17:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-17 14:35 [PATCH] make LSM register functions GPLonly exports Christoph Hellwig
2002-10-17 15:07 ` Greg KH
2002-10-17 15:13   ` Christoph Hellwig
2002-10-17 16:21   ` Jeff Garzik
2002-10-17 16:51   ` Crispin Cowan
2002-10-17 16:54     ` Christoph Hellwig
2002-10-17 17:08       ` Linus Torvalds
2002-10-17 17:20         ` Greg KH [this message]
2002-10-17 17:25         ` Linus Torvalds
2002-10-17 20:39           ` Ingo Molnar
2002-10-17 17:44         ` Crispin Cowan
2002-10-17 18:03           ` Arjan van de Ven
2002-10-17 17:20       ` Richard B. Johnson
2002-10-17 17:26         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021017172005.GE31464@kroah.com \
    --to=greg@kroah.com \
    --cc=crispin@wirex.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.