From: Greg KH <greg@kroah.com>
To: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"Patterson, David H" <david.h.patterson@intel.com>,
"Carbonari, Steven" <steven.carbonari@intel.com>,
"Abel, Michael J" <michael.j.abel@intel.com>,
"Tarabini, Anthony" <anthony.tarabini@intel.com>,
"'andreasW@ati.com'" <andreasW@ati.com>,
"Abdul-Khaliq, Rushdan" <rushdan.abdul-khaliq@intel.com>
Subject: Re: [PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support
Date: Thu, 17 Oct 2002 20:57:20 -0700 [thread overview]
Message-ID: <20021018035720.GA3326@kroah.com> (raw)
In-Reply-To: <D1C0BF20D4AFD411AB98009027AE99881167C7BF@fmsmsx40.fm.intel.com>
On Thu, Oct 17, 2002 at 11:13:19AM -0700, Tolentino, Matthew E wrote:
> Attached is a patch for generic AGP 3.0 device detection and enabling
> routines as well as specific support for the Intel 7505 chipset against the
> 2.5.43 kernel.
Just a minor comment:
diff -urN linux-2.5.43-vanilla/drivers/char/agp/Makefile linux-2.5.43/drivers/char/agp/Makefile
--- linux-2.5.43-vanilla/drivers/char/agp/Makefile Tue Oct 15 20:27:49 2002
+++ linux-2.5.43/drivers/char/agp/Makefile Thu Oct 17 10:12:41 2002
@@ -3,12 +3,13 @@
# space ioctl interface to use agp memory. It also adds a kernel interface
# that other drivers could use to manipulate agp memory.
-export-objs := agp.o
+export-objs := agp.o agp3.o
-agpgart-y := agp.o frontend.o
+agpgart-y := agp.o agp3.o frontend.o
agpgart-$(CONFIG_AGP_INTEL) += i8x0-agp.o
agpgart-$(CONFIG_AGP_I810) += i810-agp.o
+agpgart-$(CONFIG_AGP_I7505) += i7505-agp.o
agpgart-$(CONFIG_AGP_VIA) += via-agp.o
agpgart-$(CONFIG_AGP_AMD) += amd-agp.o
agpgart-$(CONFIG_AGP_SIS) += sis-agp.o
You should probably not build agp3.o unless i7505-agp.o is built too, or
do some of the other drivers need functions in agp3.c?
thanks,
greg k-h
next prev parent reply other threads:[~2002-10-18 3:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 18:13 [PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support Tolentino, Matthew E
2002-10-18 3:57 ` Greg KH [this message]
2002-10-18 15:04 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021018035720.GA3326@kroah.com \
--to=greg@kroah.com \
--cc=andreasW@ati.com \
--cc=anthony.tarabini@intel.com \
--cc=david.h.patterson@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=michael.j.abel@intel.com \
--cc=rushdan.abdul-khaliq@intel.com \
--cc=steven.carbonari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.