From: Christoph Hellwig <hch@sgi.com>
To: "Matt D. Robinson" <yakker@aparity.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.44: lkcd (7/9): dump configuration
Date: Mon, 21 Oct 2002 16:52:40 -0400 [thread overview]
Message-ID: <20021021165240.A14993@sgi.com> (raw)
In-Reply-To: <200210211016.g9LAG1V21200@nakedeye.aparity.com>; from yakker@aparity.com on Mon, Oct 21, 2002 at 03:16:01AM -0700
> +tristate 'Crash dump support' CONFIG_CRASH_DUMP
I"m very unhappy with this beeing a tristate. We have the following
things depend on it either builtin or modular:
(1) build Kerntypes
(2) do not send smp_stop_cpu
and the following goes into dump.o:
(3) dump_base.c
(4) dump_<arch>.c
Of those (2) should be replaced by a dump_in_progress check so
that we poweroff even with dumping enabled, but not in progress.
The question is whether we should make (1) unconditional either
or make it a separate bool (CONFIG_KERNELTYPES) so that that dump.o
could be load into any such kernel. But imho CONFIG_CRASH_DUMP
should just become a bool - this way dump_<arch>.c could be moved
into arch/<arch>/kernel and a lot of exports could be remove.
It's not much code either and the actual dump drivers stay modular.
next prev parent reply other threads:[~2002-10-21 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-21 10:16 [PATCH] 2.5.44: lkcd (7/9): dump configuration Matt D. Robinson
2002-10-21 20:52 ` Christoph Hellwig [this message]
2002-10-21 20:48 ` Matt D. Robinson
2002-10-22 5:03 ` Christoph Hellwig
2002-10-22 8:48 ` Suparna Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021021165240.A14993@sgi.com \
--to=hch@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yakker@aparity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.