From: Sam Ravnborg <sam@ravnborg.org>
To: Khalid Aziz <khalid@fc.hp.com>
Cc: linux-kernel@vger.kernel.org, khalid@hp.com
Subject: Re: [PATCH] Retrieve configuration information from kernel
Date: Mon, 21 Oct 2002 19:42:21 +0200 [thread overview]
Message-ID: <20021021194221.A1817@mars.ravnborg.org> (raw)
In-Reply-To: <E183g5n-0004dC-00@lyra.fc.hp.com>; from khalid@fc.hp.com on Mon, Oct 21, 2002 at 11:11:51AM -0600
On Mon, Oct 21, 2002 at 11:11:51AM -0600, Khalid Aziz wrote:
I like the concept.
Few comments:
Touching all defconfigs is not good. Try to limit the impact of the patch.
People just have to press return two more times when running oldconfig.
> diff -urN --exclude-from=/linux/diff_exclude_file linux-2.5.44/kernel/Makefile linux-2.5.44-ikconfig/kernel/Makefile
> include $(TOPDIR)/Rules.make
> +
> +$(obj)/ikconfig.h: $(TOPDIR)/scripts/mkconfigs $(TOPDIR)/.config $(TOPDIR)/Makefile
> + chmod 755 $(TOPDIR)/scripts/mkconfigs
> + $(TOPDIR)/scripts/mkconfigs $(TOPDIR)/.config $(TOPDIR)/Makefile > $(obj)/ikconfig.h
> +
> +$(obj)/configs.o: $(obj)/ikconfig.h $(obj)/configs.c \
> + $(TOPDIR)/include/linux/version.h \
> + $(TOPDIR)/include/linux/compile.h
Please avoid using $(TOPDIR)
The build is running from root of the kernel tree anyway, so it is nor required.
Use $(CONFIG_SHELL) when executing scripts, to avoid the necessity to have the executable
bit set.
Sam
next prev parent reply other threads:[~2002-10-21 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-21 17:11 [PATCH] Retrieve configuration information from kernel Khalid Aziz
2002-10-21 17:42 ` Sam Ravnborg [this message]
2002-10-21 22:31 ` Nicholas Wourms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021021194221.A1817@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=khalid@fc.hp.com \
--cc=khalid@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.