Re: [BK PATCH 1/4] fix NGROUPS hard limit (resend)

[Jesse Pollard <pollard@admin.navo.hpc.mil>]

On Tuesday 22 October 2002 12:37 pm, Tim Hockin wrote:
> Alan Cox wrote:
> > On Tue, 2002-10-22 at 18:26, Tim Hockin wrote:
> >>Alan Cox wrote:
> >>>Ok sanity check time. Why do you need qsort and bsearch for this kind of
> >>>thing. Just how many groups do you plan to support ?
> >>
> >>Unlimited - we've tested with tens of thousands.
> >
> > Now how about the real world requirements ?
>
> Those were real world requirements - we got the number 10,000 from our
> product management, which (presumably) spoke with customers.  On the
> hosting systems, it is really possible to have thousands of virtual sites.
>
> Now, I don't much care if you want it to be a linear search, and I'll
> revert it, if needed, but qsort() is already in in XFS specific code,
> and bsearch is small.  It doesn't negatively impact any fast path, and
> provides better behavior for the crazies that really want 10,000 groups.
>
> Tim

Does it actually work with NFS???? or any networked file system?
Most of them limit ngroups to 16 to 32, and cannot send any data
if there is an overflow, since that overflow would replace all of the
data you try to send/recieve...

And I really doubt that anybody has 10000 unique groups (or even
close to that) running under any system. The center I'm at has
some of the largest UNIX systems ever made, and there are only
about 600 unique groups over the entire center. The largest number
of groups a user can be in is 32. And nobody even comes close.
-- 
-------------------------------------------------------------------------
Jesse I Pollard, II
Email: pollard@navo.hpc.mil

Any opinions expressed are solely my own.