From: Jan Kasprzak <kas@informatics.muni.cz>
To: Christoph Hellwig <hch@infradead.org>,
Andries Brouwer <aebr@win.tue.nl>,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br
Subject: Re: 2.4.20-pre11 /proc/partitions read
Date: Wed, 23 Oct 2002 11:13:54 +0200 [thread overview]
Message-ID: <20021023111353.M20511@fi.muni.cz> (raw)
In-Reply-To: <20021022194514.B3867@infradead.org>; from hch@infradead.org on Tue, Oct 22, 2002 at 07:45:14PM +0100
Christoph Hellwig wrote:
: I rather suspect it's the following bug (introduce by me, but not
: depend on CONFIG_BLK_STATS):
:
: --- 1.23/drivers/block/genhd.c Wed Aug 21 10:03:48 2002
: +++ edited/drivers/block/genhd.c Tue Oct 22 20:43:16 2002
: @@ -155,13 +155,14 @@
:
: #ifdef CONFIG_PROC_FS
: /* iterator */
: -static void *part_start(struct seq_file *s, loff_t *pos)
: +static void *part_start(struct seq_file *s, loff_t *ppos)
: {
: struct gendisk *gp;
: + loff_t pos = *ppos;
:
: read_lock(&gendisk_lock);
: for (gp = gendisk_head; gp; gp = gp->next)
: - if (!*pos--)
: + if (!pos--)
: return gp;
: return NULL;
: }
Yes, this patch fixes my problem. Thanks!
-Yenya
--
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/ Czech Linux Homepage: http://www.linux.cz/ |
|-- If you start doing things because you hate others and want to screw --|
|-- them over the end result is bad. --Linus Torvalds to the BBC News --|
prev parent reply other threads:[~2002-10-23 9:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 14:19 2.4.20-pre11 /proc/partitions read Jan Kasprzak
2002-10-22 15:10 ` Richard B. Johnson
2002-10-22 16:14 ` Jan Kasprzak
2002-10-22 18:40 ` Andries Brouwer
2002-10-22 18:10 ` Marcelo Tosatti
2002-10-23 8:36 ` Jan Kasprzak
2002-10-22 18:45 ` Christoph Hellwig
2002-10-22 18:59 ` Andries Brouwer
2002-10-22 18:26 ` Marcelo Tosatti
2002-10-22 19:32 ` Andries Brouwer
2002-10-22 19:35 ` Christoph Hellwig
2002-10-22 19:58 ` Andries Brouwer
2002-10-22 20:32 ` Alan Cox
2002-10-23 8:39 ` Jan Kasprzak
2002-10-23 9:13 ` Jan Kasprzak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021023111353.M20511@fi.muni.cz \
--to=kas@informatics.muni.cz \
--cc=aebr@win.tue.nl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.