Re: [PATCH] New ARPHRD types

[Solomon Peachy <solomon@linux-wlan.com>]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

On Thu, Oct 24, 2002 at 04:38:56PM +0100, Alan Cox wrote:
> On Thu, 2002-10-24 at 15:58, Solomon Peachy wrote:
> > 1) audit the use of hard_header_len in net/* and submit fixes
> We've handled variable length headers for years so that bit I do trust.

And that's exactly what I wanted to know, thanks.

Out of curiousity, how far back to you trust the code? 2.2? 2.0? I only
ask because a lot of the driver work I do is for underpowered
embedded targets running relatively ancient 2.0 kernels. 

> AX.25 even has variable length headers on ARP frames 8)

Eww.  

> > 2) write an 802.11 equivalent of the code in eth.c
> That may be much cleaner and easier to get right. Its also easier to
> maintain

That's what I've been planning to do all along.   It will be nice not
having to convert 802.3<-->802.11 in every wireless driver.. plus the
added benefit of not having to realloc/memcpy buffers to work around
dumb DMA engines that require contiguious buffers..

 - Pizza
-- 
Solomon Peachy                        solomon@linux-wlan.com
AbsoluteValue Systems                 http://www.linux-wlan.com
715-D North Drive                     +1 (321) 259-0737  (office)
Melbourne, FL 32934                   +1 (321) 259-0286  (fax)

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]