Re: [PATCH] 2.5.44-ac3, cciss, more scatter gather elements

[Jens Axboe <axboe@suse.de>]

On Fri, Oct 25 2002, Jens Axboe wrote:
> On Fri, Oct 25 2002, Cameron, Steve wrote:
> > Jens Axboe wrote:
> > > On Fri, Oct 25 2002, Stephen Cameron wrote:
> > > > 
> > > > Add blk_rq_map_sg_one_by_one function to ll_rw_blk.c in order to allow a low 
> > > > level driver to map scatter gather elements from the block subsystem one 
> > > > at a time 
> > [...]
> > > I have to say that I think this patch is ugly, and a complete 
> > > duplicate of existing code. This is always bad, especially in the case of
> > > something not really straight forward (like blk_rq_map_sg()). A hack.
> > 
> > Yes, I sort of figured you'd say that.  I was just trying to get the 
> > ball rolling.
> 
> I was hoping that was the case and you weren't really serious :-). I've
> cut a draft version of this, it's not tested at all though to be
> careful... It should do what you want, yes? I'm not too happy with this
> one, need a bit more time to ponder.

Well no doubt that this is much cleaner. It just needs to be evaluated
for over head... It does incur an extra function call per segment
mapped. On the other hand, we save the conditional and branch. IOW, I'll
probably go with this one.

-- 
Jens Axboe