From: Sam Ravnborg <sam@ravnborg.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: linux-2.5.44uc1 (MMU-less support)
Date: Sat, 26 Oct 2002 22:18:56 +0200 [thread overview]
Message-ID: <20021026201856.GA1670@mars.ravnborg.org> (raw)
In-Reply-To: <3DBAC09A.4090104@snapgear.com>
On Sun, Oct 27, 2002 at 02:19:38AM +1000, Greg Ungerer wrote:
> - arch Makefiles rewritten
Took a look at them.
See comments below.
Sam
diff -Naur linux-2.5.44/arch/m68knommu/Makefile linux-2.5.44uc1/arch/m68knommu/Makefile
--- linux-2.5.44/arch/m68knommu/Makefile Thu Jan 1 10:00:00 1970
+++ linux-2.5.44uc1/arch/m68knommu/Makefile Sun Oct 27 02:09:09 2002
+PLATFORM = $(platform-y)
Use := no late evaluation required.
+MODEL = $(model-y)
See above.
+cpuclass-$(CONFIG_M68VZ328) := 68328
+CPUCLASS = $(cpuclass-y)
+CLASSDIR = arch/m68knommu/platform/$(cpuclass-y)/
ditto
+CLEAN_FILES += include/asm-$(ARCH)/asm-offsets.h.tmp \
+ include/asm-$(ARCH)/asm-offsets.h \
+ arch/$(ARCH)/kernel/asm-offsets.s
Use the new clean infrastrucute.
clean-files := include/asm-$(ARCH)/asm-offsets.h.tmp \
include/asm-$(ARCH)/asm-offsets.h \
arch/$(ARCH)/kernel/asm-offsets.s
+prepare: include/asm-$(ARCH)/asm-offsets.h
+archclean:
Add a call to clean boot - something like
$(call descend arch/$(ARCH)/boot, subdirclean)
+
+arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h \
+ include/config/MARKER
+
+include/asm-$(ARCH)/asm-offsets.h.tmp: arch/$(ARCH)/kernel/asm-offsets.s
+ @$(generate-asm-offsets.h) < $< > $@
+
+include/asm-$(ARCH)/asm-offsets.h: include/asm-$(ARCH)/asm-offsets.h.tmp
+ @echo -n ' Generating $@'
+ @$(update-if-changed)
Combine it like this instead:
include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
include/asm include/linux/version.h \
include/config/MARKER
@echo -n ' Generating $@'
@$(generate-asm-offsets.h) < $< > $@
@$(update-if-changed)
Thats more readable, and follow te normal way of doing it.
diff -Naur linux-2.5.44/arch/m68knommu/boot/Makefile linux-2.5.44uc1/arch/m68knommu/boot/Makefile
--- linux-2.5.44/arch/m68knommu/boot/Makefile Thu Jan 1 10:00:00 1970
+++ linux-2.5.44uc1/arch/m68knommu/boot/Makefile Sun Oct 27 02:09:08 2002
@@ -0,0 +1,5 @@
+clean:
+ rm -f *.[oa]
+
+dep depend:
+ :
The above can safely be deleted.
General comment.
Use
EXTRA_TARGET :=
in replacement for
EXTRA_TARGETS =
Thas is required in many platform specific makefiles
diff -Naur linux-2.5.44/arch/m68knommu/platform/68328/Makefile linux-2.5.44uc1/arch/m68knommu/platform/68328/Makefile
+
+arch/m68knommu/platform/68328/$(BOARD)/bootlogo.rh: arch/m68knommu/platform/68328/bootlogo.h
+ perl arch/m68knommu/platform/68328/bootlogo.pl \
+ < arch/m68knommu/platform/68328/bootlogo.h \
+ > arch/m68knommu/platform/68328/$(BOARD)/bootlogo.rh
The following is more readable:
$obj)/$(BOARD)/bootlogo.rh: $(src)/bootlogo.h
$(PERL) $(src)/bootlogo.pl < $(src)/bootlogo.h
> $(obj)/$(BOARD)/bootlogo.rh
diff -Naur linux-2.5.44/arch/m68knommu/platform/68EZ328/Makefile linux-2.5.44uc1/arch/m68knommu/platform/68EZ328/Makefile
+
$(obj)/$(BOARD)/bootlogo.rh: $(src)/bootlogo.h
$(PERL) $(src)/bootlogo.pl < $(src)/bootlogo.h \
> $(obj)/$(BOARD)/bootlogo.rh
The same changes a listed above.
diff -Naur linux-2.5.44/arch/m68knommu/platform/68VZ328/Makefile linux-2.5.44uc1/arch/m68knommu/platform/68VZ328/Makefile
+arch/m68knommu/platform/68VZ328/$(BOARD)/bootlogo.rh: arch/m68knommu/platform/68EZ328/bootlogo.h
+ perl arch/m68knommu/platform/68328/bootlogo.pl \
+ < arch/m68knommu/platform/68EZ328/bootlogo.h \
+ > arch/m68knommu/platform/68VZ328/$(BOARD)/bootlogo.rh
Again - use $(obj) - $(src)
diff -Naur linux-2.5.44/arch/m68knommu/platform/Makefile linux-2.5.44uc1/arch/m68knommu/platform/Makefile
@@ -0,0 +1,6 @@
+#
+# Makefile for the arch/m68knommu/platform.
+#
+
+include $(TOPDIR)/Rules.make
+
This makefile looks not at all usefull for me.
next prev parent reply other threads:[~2002-10-26 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-26 16:19 [PATCH]: linux-2.5.44uc1 (MMU-less support) Greg Ungerer
2002-10-26 20:18 ` Sam Ravnborg [this message]
2002-10-27 14:15 ` Greg Ungerer
2002-10-28 3:53 ` Miles Bader
2002-10-28 4:13 ` Miles Bader
2002-10-28 5:11 ` Greg Ungerer
[not found] <fa.fd5mvtv.9gon33@ifi.uio.no>
2002-10-27 4:04 ` Miles Bader
2002-10-27 7:48 ` Sam Ravnborg
2002-10-27 11:15 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021026201856.GA1670@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.