From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: verbose argument to sd_synchronize_cache
Date: Sun, 27 Oct 2002 10:35:19 -0600 [thread overview]
Message-ID: <200210271635.g9RGZJ111449@localhost.localdomain> (raw)
In-Reply-To: Message from Christoph Hellwig <hch@infradead.org> of "Sun, 27 Oct 2002 16:28:11 GMT." <20021027162811.A21987@infradead.org>
hch@infradead.org said:
> sd_synchronize_cache() is always called with verbose=1, so this
> argument should go away. But do we really want to be that verbose
> here? IMHO we should remove the argumet and the printks..
It can take a while to synchronise the cache on monster arrays, so printing
something while we do it on shutdown is a good idea (unless you want the "my
machine takes ages to shut down" type of bug reports).
The non-verbose part was for exposing the synchronise via an ioctl (which I
haven't got around to writing yet) on the grounds that anyone doing the ioctl
knows what's going on and doesn't need a kernel message telling them.
James
prev parent reply other threads:[~2002-10-27 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-27 16:28 verbose argument to sd_synchronize_cache Christoph Hellwig
2002-10-27 16:35 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210271635.g9RGZJ111449@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.