From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix sector_div use in scsicam.c
Date: Sun, 27 Oct 2002 17:37:56 +0100 [thread overview]
Message-ID: <20021027173756.A16077@lst.de> (raw)
In-Reply-To: <200210271634.g9RGYAY11441@localhost.localdomain>; from James.Bottomley@steeleye.com on Sun, Oct 27, 2002 at 10:34:09AM -0600
On Sun, Oct 27, 2002 at 10:34:09AM -0600, James Bottomley wrote:
> > - ip[2] = sector_div(capacity, ip[0] * ip[1]);
> > + sector_div(capacity, ip[0] * ip[1]);
> > + ip[2] = capacity;
>
> Now you've lost your optimisation. The second sector_div should be inside the
> if.
Next try:
--- 1.11/drivers/scsi/scsicam.c Fri Oct 25 13:31:53 2002
+++ edited/drivers/scsi/scsicam.c Sun Oct 27 16:36:31 2002
@@ -80,11 +80,13 @@
if (ret || ip[0] > 255 || ip[1] > 63) {
ip[0] = 64;
ip[1] = 32;
- if (sector_div(capacity, ip[0] * ip[1]) > 65534) {
+ sector_div(capacity, ip[0] * ip[1]);
+ if (capacity > 65534) {
ip[0] = 255;
ip[1] = 63;
+ sector_div(capacity, ip[0] * ip[1]);
}
- ip[2] = sector_div(capacity, ip[0] * ip[1]);
+ ip[2] = capacity;
}
return 0;
next prev parent reply other threads:[~2002-10-27 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-27 16:02 [PATCH] fix sector_div use in scsicam.c Christoph Hellwig
2002-10-27 16:21 ` James Bottomley
2002-10-27 16:23 ` Christoph Hellwig
2002-10-27 16:34 ` James Bottomley
2002-10-27 16:37 ` Christoph Hellwig [this message]
2002-10-27 19:22 ` Andries Brouwer
2002-10-27 20:53 ` James Bottomley
2002-10-27 22:10 ` Andries Brouwer
2002-10-28 0:05 ` James Bottomley
2002-10-28 0:50 ` Andries Brouwer
2002-10-28 1:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021027173756.A16077@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.