From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: possible use-after-free in 2.5.44 scsi changes Date: Sun, 27 Oct 2002 22:20:35 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20021027212035.GM3966@suse.de> References: <20021026092943.GB14976@suse.de> <200210270050.g9R0oQe04795@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200210270050.g9R0oQe04795@localhost.localdomain> List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Badari Pulavarty , Andrew Morton , "linux-scsi@vger.kernel.org" , "Martin J. Bligh" , Doug Ledford On Sat, Oct 26 2002, James Bottomley wrote: > axboe@suse.de said: > > Irk no, you cannot just clear valid information! This is _not_ a fix, > > it's a hack. > > > Use a different flag, or maybe use REQ_DONTPREP or similar. > > OK, what about this. It uses REQ_DONTPREP, and could be a precursor > to moving the SCSI subsystem to using the request prep function. Sure that would suffice, but lets just move to the prep approach right away. First just the global one, later we can do one per device type. -- Jens Axboe