All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: willy@debian.org
Cc: alan@lxorguk.ukuu.org.uk, rmk@arm.linux.org.uk, hugh@veritas.com,
	akpm@zip.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem missing cache flush
Date: Mon, 28 Oct 2002 08:55:36 -0800 (PST)	[thread overview]
Message-ID: <20021028.085536.32752918.davem@redhat.com> (raw)
In-Reply-To: <20021028163649.P27461@parcelfarce.linux.theplanet.co.uk>

   From: Matthew Wilcox <willy@debian.org>
   Date: Mon, 28 Oct 2002 16:36:49 +0000

   While we're on the subject of cache flushing... these make no sense:
   
   fs/binfmt_aout.c:357:           flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data);
   fs/binfmt_aout.c:381:                   flush_icache_range((unsigned long) N_TXTADDR(ex),
   fs/binfmt_aout.c:479:           flush_icache_range((unsigned long) start_addr,
   fs/binfmt_elf.c:422:    flush_icache_range((unsigned long)addr,
   
   the kernel doesn't execute the code ranges here, userspace does.  Which
   means that the only place in the entire kernel which does need to call
   flush_icache_range() is kernel/module.c, and that could all be done in
   module_arch_init().  So I think we don't need flush_icache_range() at all.

Need to go into the revision history, discover who added these
calls, and ask them why they were added.

  reply	other threads:[~2002-10-28 16:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-16 18:26 [PATCH] shmem missing cache flush Matthew Wilcox
2002-10-16 23:57 ` Hugh Dickins
2002-10-16 23:58   ` David S. Miller
2002-10-17  0:19     ` Russell King
2002-10-17  0:16       ` David S. Miller
2002-10-21 15:04         ` Alan Cox
2002-10-21 15:21           ` David S. Miller
2002-10-21 16:12             ` Alan Cox
2002-10-28 14:10               ` David S. Miller
2002-10-28 14:32                 ` Matthew Wilcox
2002-10-28 14:26                   ` David S. Miller
2002-10-28 16:36                     ` Matthew Wilcox
2002-10-28 16:55                       ` David S. Miller [this message]
2002-10-28 17:06                         ` Matthew Wilcox
2002-10-28 16:58                           ` David S. Miller
2002-10-29 21:52                             ` Matthew Wilcox
2002-10-28 17:08                       ` Alan Cox
2002-10-28 16:52                         ` Matthew Wilcox
2002-10-28 14:35                 ` Hugh Dickins
2002-10-28 14:26                   ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2002-10-28 16:50 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021028.085536.32752918.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@zip.com.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.