From: Christoph Hellwig <hch@infradead.org>
To: Steven Dake <sdake@mvista.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI and FibreChannel Hotswap for linux 2.5.44-bk2
Date: Wed, 30 Oct 2002 20:18:34 +0000 [thread overview]
Message-ID: <20021030201834.A4815@infradead.org> (raw)
In-Reply-To: <3DC02AF7.6020209@mvista.com>; from sdake@mvista.com on Wed, Oct 30, 2002 at 11:54:47AM -0700
Umm, stop.
Scsi midlayer patches don't go directly to Linus, but through the linux-scsi
list and James into the linux-scsi bk repository first.
The patch still has a bunch of problem not solved, and contains two things
that should be independant patches.
The first patch should be the host_queue locking you added, this one currently
has the following issues:
* you call spin_lock on a semaphore once!
* you take semaphores inside spinlocks and with interrupts disabled
* the coding style needs some imnprovements (you adds lots of empty lines,
and there's a space before the opening brakes of function calls).
the actual driver still has other issues:
* you still duplicated lots of code from scsi.c
* your header is still in include/linux instead of include/scsi,
but imho it should be merged into scsi.h anyway
* you still havent explain why wwn -> host id translation can't
be done in userspace
* you still have useage information in the driverfs files.
next prev parent reply other threads:[~2002-10-30 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-30 18:54 [PATCH] SCSI and FibreChannel Hotswap for linux 2.5.44-bk2 Steven Dake
2002-10-30 19:45 ` Alan Cox
2002-10-30 19:29 ` Linus Torvalds
2002-10-30 19:29 ` Linus Torvalds
2002-10-30 21:17 ` Doug Ledford
2002-10-30 20:31 ` Scott Murray
2002-10-30 20:31 ` Scott Murray
2002-10-30 20:18 ` Christoph Hellwig [this message]
2002-10-30 21:09 ` Steven Dake
2002-10-30 20:42 ` James Bottomley
2002-11-04 2:13 ` Rob Landley
-- strict thread matches above, loose matches on Subject: below --
2002-10-30 20:50 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021030201834.A4815@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sdake@mvista.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.