All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Adam Kropelin <akropel1@rochester.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.46: ide-cd cdrecord (almost) success report
Date: Wed, 6 Nov 2002 08:44:57 +0100	[thread overview]
Message-ID: <20021106074457.GE4369@suse.de> (raw)
In-Reply-To: <20021106072223.GB4369@suse.de>

On Wed, Nov 06 2002, Jens Axboe wrote:
> > when the cdrecord buffer underran was surprising, though: oops below.
> > Very repeatable. Can supply copious hw details if it helps.
> 
> I'll try and reproduce that here, there's been a similar report (same
> oops) before. If you can just send me the dmesg output after a boot that
> should be fine.

Could you reproduce with this patch? I'd like to see the request state
when this happens.

===== drivers/ide/ide-cd.c 1.32 vs edited =====
--- 1.32/drivers/ide/ide-cd.c	Sun Nov  3 19:57:35 2002
+++ edited/drivers/ide/ide-cd.c	Wed Nov  6 08:44:04 2002
@@ -1722,6 +1722,11 @@
 			blen = bio_iovec(rq->bio)->bv_len;
 		}
 
+		if (!ptr) {
+			blk_dump_rq_flags(rq, "cdrom_newpc_intr");
+			break;
+		}
+
 		if (blen > thislen)
 			blen = thislen;
 

-- 
Jens Axboe


  reply	other threads:[~2002-11-06  7:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06  4:13 2.5.46: ide-cd cdrecord (almost) success report Adam Kropelin
2002-11-06  7:22 ` Jens Axboe
2002-11-06  7:44   ` Jens Axboe [this message]
2002-11-06 23:25     ` Adam Kropelin
2002-11-07 14:33       ` Jens Axboe
2002-11-06 15:56   ` Adam Kropelin
2002-11-06 18:11     ` Patrick Mansfield
2002-11-06 23:33       ` Adam Kropelin
2002-11-06 23:52         ` Patrick Mansfield
2002-11-07  0:05           ` Adam Kropelin
2002-11-06 18:45     ` Jens Axboe
2002-11-06 23:23       ` Adam Kropelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021106074457.GE4369@suse.de \
    --to=axboe@suse.de \
    --cc=akropel1@rochester.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.