From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Trivial Russell Subject: [TRIVIAL] [Trivial Patch] scsi_register-006 Date: Fri, 08 Nov 2002 19:26:33 +1100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20021108083827.EBCEB2C3BB@lists.samba.org> Return-path: List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org, achim@vortex.de From: Michael Still This patch has been generated as part of my scsi_register audit of the 2.5.45 kernel tree. scsi_register() can fail, returning a NULL pointer, and the failure case was not being handled here... --- trivial-2.5-bk/drivers/scsi/gdth.c.orig 2002-11-08 18:47:03.000000000 +1100 +++ trivial-2.5-bk/drivers/scsi/gdth.c 2002-11-08 18:47:03.000000000 +1100 @@ -4105,6 +4105,9 @@ break; if (gdth_search_eisa(eisa_slot)) { /* controller found */ shp = scsi_register(shtp,sizeof(gdth_ext_str)); + if(shp == NULL) + continue; + ha = HADATA(shp); if (!gdth_init_eisa(eisa_slot,ha)) { scsi_unregister(shp); -- Don't blame me: the Monkey is driving File: Michael Still : [Trivial Patch] scsi_register-006