From: Russell King <rmk@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Paul Mackerras <paulus@samba.org>, Jens Axboe <axboe@suse.de>,
Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
benh@kernel.crashing.org
Subject: Re: [PATCH] Fix typo in sl82c105.c driver
Date: Fri, 8 Nov 2002 17:41:53 +0000 [thread overview]
Message-ID: <20021108174153.B24905@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1036777109.16651.43.camel@irongate.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Fri, Nov 08, 2002 at 05:38:29PM +0000
On Fri, Nov 08, 2002 at 05:38:29PM +0000, Alan Cox wrote:
> On Thu, 2002-11-07 at 02:55, Paul Mackerras wrote:
> > This patch fixes a minor typo in sl82c105.c which stops it from
> > compiling.
> >
> > Jens and/or Linus, please apply.
> >
> > Paul.
> >
> > diff -urN linux-2.5/drivers/ide/pci/sl82c105.c pmac-2.5/drivers/ide/pci/sl82c105.c
> > --- linux-2.5/drivers/ide/pci/sl82c105.c 2002-10-12 14:40:28.000000000 +1000
> > +++ pmac-2.5/drivers/ide/pci/sl82c105.c 2002-10-30 12:32:48.000000000 +1100
> > @@ -284,7 +284,7 @@
> >
> > static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_device_id *id)
> > {
> > - ide_pci_device_t *d = &slc82c105_chipsets[id->driver_data];
> > + ide_pci_device_t *d = &sl82c105_chipsets[id->driver_data];
> > if (dev->device != d->device)
> > BUG();
> > ide_setup_pci_device(dev, d);
>
> Looks good to me
It may look good. Shame that the DMA state machine gets screwed if you
have an ATAPI device on either channel, and needs code to reset it prior
to issuing a command.
Sorry, I've not been able to push the fixes forward yet. Its on my todo
list though.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2002-11-08 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-07 2:55 [PATCH] Fix typo in sl82c105.c driver Paul Mackerras
2002-11-07 9:36 ` Russell King
2002-11-08 17:38 ` Alan Cox
2002-11-08 17:41 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021108174153.B24905@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.